From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-xfs@vger.kernel.org, chandanrlinux@gmail.com,
bfoster@redhat.com
Subject: Re: [PATCH 3/3] xfs: shorten the shutdown messages to a single line
Date: Mon, 21 Jun 2021 07:06:40 +0100 [thread overview]
Message-ID: <YNAscPMObALPLYLa@infradead.org> (raw)
In-Reply-To: <20210621060222.GU664593@dread.disaster.area>
On Mon, Jun 21, 2021 at 04:02:22PM +1000, Dave Chinner wrote:
> > > if (flags & SHUTDOWN_FORCE_UMOUNT) {
> > > xfs_alert(mp,
> > > -"User initiated shutdown received. Shutting down filesystem");
> > > +"User initiated shutdown (0x%x) received. Shutting down filesystem",
> > > + flags);
> > > return;
> > > }
> >
> > So SHUTDOWN_FORCE_UMOUNT can actually be used together with
> > SHUTDOWN_LOG_IO_ERROR so printing something more specific could be
> > useful, although I'd prefer text over the hex flags.
>
> I'm in the process of reworking the shutdown code because shutdown
> is so, so very broken. Can we just fix the message and stop moving
> the goal posts on me while I try to fix bugs?
I suggest just not adding these not very useful flags. That is not
moving the goal post. And I'm growing really tried of this pointlessly
aggressive attitude.
next prev parent reply other threads:[~2021-06-21 6:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 18:53 [PATCHSET v2 0/3] xfs: various small fixes and cleanups Darrick J. Wong
2021-06-18 18:53 ` [PATCH 1/3] xfs: fix type mismatches in the inode reclaim functions Darrick J. Wong
2021-06-20 22:23 ` Dave Chinner
2021-06-18 18:54 ` [PATCH 2/3] xfs: print name of function causing fs shutdown instead of hex pointer Darrick J. Wong
2021-06-20 22:24 ` Dave Chinner
2021-06-21 4:41 ` Chandan Babu R
2021-06-21 5:26 ` Christoph Hellwig
2021-06-18 18:54 ` [PATCH 3/3] xfs: shorten the shutdown messages to a single line Darrick J. Wong
2021-06-20 22:29 ` Dave Chinner
2021-06-21 4:41 ` Chandan Babu R
2021-06-21 5:30 ` Christoph Hellwig
2021-06-21 6:02 ` Dave Chinner
2021-06-21 6:06 ` Christoph Hellwig [this message]
2021-06-21 6:29 ` Dave Chinner
2021-06-21 16:56 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNAscPMObALPLYLa@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=chandanrlinux@gmail.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox