From: Michal Hocko <mhocko@suse.com>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: Dave Chinner <david@fromorbit.com>,
linux-xfs@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/3] mm: Add kvrealloc()
Date: Wed, 30 Jun 2021 14:05:35 +0200 [thread overview]
Message-ID: <YNxeD2W32x8wJ/87@dhcp22.suse.cz> (raw)
In-Reply-To: <20210630100455.GI3840@techsingularity.net>
On Wed 30-06-21 11:04:55, Mel Gorman wrote:
[...]
> I didn't do a full audit to determine what fallout, if any, there is
> to ultimately passing __GFP_NOFAIL to kvmalloc although kvmalloc_node
> explicitly notes that __GFP_NOFAIL is not supported. Adding Michal Hocko
> to the cc to see if he remembers why __GFP_NOFAIL was problematic.
This is because there are allocations in the vmalloc path which do not
get the full gfp context. E.g. page table allocations. This could be
likely handled somewhere at the vmalloc layer and retry but I do not
remember anybody would be really requesting the support.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-06-30 12:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 6:14 [PATCH 0/3 v2] mm, xfs: memory allocation improvements Dave Chinner
2021-06-30 6:14 ` [PATCH 1/3] mm: Add kvrealloc() Dave Chinner
2021-06-30 10:04 ` Mel Gorman
2021-06-30 12:05 ` Michal Hocko [this message]
2021-06-30 16:08 ` Darrick J. Wong
2021-06-30 21:49 ` Dave Chinner
2021-06-30 6:14 ` [PATCH 2/3] xfs: remove kmem_alloc_io() Dave Chinner
2021-06-30 16:09 ` Darrick J. Wong
2021-06-30 6:14 ` [PATCH 3/3] xfs: replace kmem_alloc_large() with kvmalloc() Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2021-07-14 2:34 [PATCH 0/3 v3] xfs, mm: memory allocation improvements Dave Chinner
2021-07-14 2:34 ` [PATCH 1/3] mm: Add kvrealloc() Dave Chinner
2021-07-14 11:05 ` Mel Gorman
2021-07-14 21:15 ` Darrick J. Wong
2021-06-25 2:30 [PATCH 0/3] mm, xfs: memory allocation improvements Dave Chinner
2021-06-25 2:30 ` [PATCH 1/3] mm: Add kvrealloc() Dave Chinner
2021-06-25 2:40 ` Miaohe Lin
2021-06-25 5:05 ` Dave Chinner
2021-06-25 3:54 ` Matthew Wilcox
2021-06-25 5:02 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNxeD2W32x8wJ/87@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=david@fromorbit.com \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mgorman@techsingularity.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox