From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CF9BC11F6C for ; Wed, 14 Jul 2021 07:01:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 473C96136E for ; Wed, 14 Jul 2021 07:01:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238259AbhGNHEm (ORCPT ); Wed, 14 Jul 2021 03:04:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238245AbhGNHEl (ORCPT ); Wed, 14 Jul 2021 03:04:41 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F096C061574 for ; Wed, 14 Jul 2021 00:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7WwolqtDLIs9Ob2iKh8bgTto4l5PZ/EjsbYAfsGb2GA=; b=TbaRJcHAxqoTdD/y5phUh6BT+7 Yr4ZER5W+8lnwDgyNPZXv+OrWG32hZKiO1KeLHeqmo088LRO5x/y2qyTrdpBogJBYztlsc08ivtAh es71CxM5CkMOItqLQFJdWPJQXLWjTR2sL79ZyGi7CYbUGhYTSooYMY3cXzD7TpWyEfzM0OmHvf5qH e7elHFATaESAaMfe4s6pzT9rJ0u2jymLnDQCyzASiIv61u2W7QbhSwrXzN2aNNAqOgRGU9Osyaxpo mn73/fNuA8OvmbDJPnVpbb6JlNL5QdKi2RPHSFEJ+DKpt5CyKdWOCY46lUMIpiibvhlBxzKPM5q/Q ulgDBtkw==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3YtW-001wXm-Gr; Wed, 14 Jul 2021 07:01:32 +0000 Date: Wed, 14 Jul 2021 08:01:22 +0100 From: Christoph Hellwig To: Dave Chinner Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 04/16] xfs: reflect sb features in xfs_mount Message-ID: References: <20210714041912.2625692-1-david@fromorbit.com> <20210714041912.2625692-5-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210714041912.2625692-5-david@fromorbit.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Jul 14, 2021 at 02:19:00PM +1000, Dave Chinner wrote: > From: Dave Chinner > > Currently on-disk feature checks require decoding the superblock > fileds and so can be non-trivial. We have almost 400 hundred > individual feature checks in the XFS code, so this is a significant > amount of code. To reduce runtime check overhead, pre-process all > the version flags into a features field in the xfs_mount at mount > time so we can convert all the feature checks to a simple flag > check. > > There is also a need to convert the dynamic feature flags to update > the m_features field. This is required for attr, attr2 and quota > features. New xfs_mount based wrappers are added for this. Nice! I've been thinking about something like this for a while to start decoupling the mount structure from the log sb, similar to what we did for the inode. Reviewed-by: Christoph Hellwig