From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>, xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: don't expose misaligned extszinherit hints to userspace
Date: Mon, 12 Jul 2021 12:22:54 +0100 [thread overview]
Message-ID: <YOwmDlUyhHkkC05N@infradead.org> (raw)
In-Reply-To: <20210710035831.GB11588@locust>
On Fri, Jul 09, 2021 at 08:58:31PM -0700, Darrick J. Wong wrote:
> > Looks sensible, but maybe we need a pr_info_ratelimited to inform
> > the user of this case?
>
> Why? Now that I've established that the system administrator is and
> always has been allowed to invalidate the extent size hints when
> realtime volumes are in play, I don't think we need to spam the kernel
> log about the admin's strange choices.
>
> The only reason I put that xfs_info_once thing in 603f00 is because I
> mistakenly thought that the only way we could end up with a fs like that
> was due to gaps in user input sanitization, i.e. fs isn't supposed to be
> weird, but it is anyway.
Ok:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2021-07-12 11:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 4:12 [PATCH] xfs: don't expose misaligned extszinherit hints to userspace Darrick J. Wong
2021-07-09 4:14 ` [RFC PATCH] xfs: test adding realtime sections to filesystem Darrick J. Wong
2021-07-09 6:25 ` [PATCH] xfs: don't expose misaligned extszinherit hints to userspace Christoph Hellwig
2021-07-10 3:58 ` Darrick J. Wong
2021-07-12 11:22 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOwmDlUyhHkkC05N@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).