From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs: introduce xfs_buf_daddr()
Date: Thu, 12 Aug 2021 09:16:02 +0100 [thread overview]
Message-ID: <YRTYwuzgaWDprozP@infradead.org> (raw)
In-Reply-To: <YRTXkHkJeIzEfGfQ@infradead.org>
On Thu, Aug 12, 2021 at 09:10:56AM +0100, Christoph Hellwig wrote:
> On Tue, Aug 10, 2021 at 03:28:49PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Introduce a helper function xfs_buf_daddr() to extract the disk
> > address of the buffer from the struct xfs_buf. This will replace
> > direct accesses to bp->b_bn and bp->b_maps[0].bm_bn, as well as
> > the XFS_BUF_ADDR() macro.
> >
> > This patch introduces the helper function and replaces all uses of
> > XFS_BUF_ADDR() as this is just a simple sed replacement.
>
> The end result looks sane, but I would have preferred to do one patch
> that just does the script rename of XFS_BUF_ADDR, and one ore more to
> clean up the rest.
Which is exactly what this patch does - I should have looked at it
more carefully and not just the applied series.
So maybe tweak the above commit message bit, otherwise:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-08-12 8:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 5:28 [PATCH 0/3] xfs: clean up buffer cache disk addressing Dave Chinner
2021-08-10 5:28 ` [PATCH 1/3] xfs: introduce xfs_buf_daddr() Dave Chinner
2021-08-11 0:40 ` Darrick J. Wong
2021-08-12 8:10 ` Christoph Hellwig
2021-08-12 8:16 ` Christoph Hellwig [this message]
2021-08-10 5:28 ` [PATCH 2/3] xfs: convert bp->b_bn references to xfs_buf_daddr() Dave Chinner
2021-08-11 0:44 ` Darrick J. Wong
2021-08-12 8:20 ` Christoph Hellwig
2021-08-10 5:28 ` [PATCH 3/3] xfs: rename buffer cache index variable b_bn Dave Chinner
2021-08-11 0:46 ` Darrick J. Wong
2021-08-17 23:48 ` Dave Chinner
2021-08-17 23:56 ` Darrick J. Wong
2021-08-18 0:07 ` Dave Chinner
2021-08-12 8:23 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2021-08-19 0:00 [PATCH 0/3 v2] xfs: clean up buffer cache disk addressing Dave Chinner
2021-08-19 0:00 ` [PATCH 1/3] xfs: introduce xfs_buf_daddr() Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRTYwuzgaWDprozP@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).