Re: [PATCH 07/14] xfs: support dynamic btree cursor heights

Christoph Hellwig
2021-09-21T08:50:33Z

On Fri, Sep 17, 2021 at 06:29:48PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Split out the btree level information into a separate struct and put it
> at the end of the cursor structure as a VLA. The realtime rmap btree
> (which is rooted in an inode) will require the ability to support many
> more levels than a per-AG btree cursor, which means that we're going to
> create two btree cursor caches to conserve memory for the more common
> case.

This adds a whole bunch of > 80 char lines, and xfs_btree_cur_sizeof
should use struct_size().

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>