Re: [PATCH 14/14] xfs: kill XFS_BTREE_MAXLEVELS

Chandan Babu R
2021-09-20T10:12:53Z

On 18 Sep 2021 at 07:00, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Nobody uses this symbol anymore, so kill it.
>

Looks good.

Reviewed-by: Chandan Babu R <chandan.babu@oracle.com>

> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> fs/xfs/libxfs/xfs_btree.c | 2 --
> fs/xfs/libxfs/xfs_btree.h | 2 --
> 2 files changed, 4 deletions(-)
>
>
> diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c
> index 005bc42cf0bd..a7c866332911 100644
> --- a/fs/xfs/libxfs/xfs_btree.c
> +++ b/fs/xfs/libxfs/xfs_btree.c
> @@ -5003,8 +5003,6 @@ xfs_btree_alloc_cursor(
> struct xfs_btree_cur *cur;
> unsigned int maxlevels = xfs_btree_maxlevels(mp, btnum);
>
> - ASSERT(maxlevels <= XFS_BTREE_MAXLEVELS);
> -
> cur = kmem_zalloc(xfs_btree_cur_sizeof(maxlevels), KM_NOFS);
> cur->bc_tp = tp;
> cur->bc_mp = mp;
> diff --git a/fs/xfs/libxfs/xfs_btree.h b/fs/xfs/libxfs/xfs_btree.h
> index d256d869f0af..91154dd63472 100644
> --- a/fs/xfs/libxfs/xfs_btree.h
> +++ b/fs/xfs/libxfs/xfs_btree.h
> @@ -90,8 +90,6 @@ uint32_t xfs_btree_magic(int crc, xfs_btnum_t btnum);
> #define XFS_BTREE_STATS_ADD(cur, stat, val) \
> XFS_STATS_ADD_OFF((cur)->bc_mp, (cur)->bc_statoff + __XBTS_ ## stat, val)
>
> -#define XFS_BTREE_MAXLEVELS 9 /* max of all btrees */
> -
> struct xfs_btree_ops {
> /* size of the key and record structures */
> size_t key_len;

--
chandan