Re: [PATCH 18/21] iomap: Convert iomap_add_to_ioend to take a folio

Christoph Hellwig
2021-11-04T08:40:46Z

On Thu, Nov 04, 2021 at 01:38:48AM -0700, Christoph Hellwig wrote:
> > I _think_ we restrict the maximum file size to 2^63 - 1 to avoid i_size
> > ever being negative. But that means that end_pos might be 2^63 (ie
> > LONG_MIN), so we need to subtract one from it to get the right answer.
> > Maybe worth a comment?
>
> Yes, please.

Or we should stick to the u64 type that the existing code uses to side
step that whole issue..