From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D11BC433EF for ; Wed, 6 Apr 2022 18:01:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239711AbiDFSDj (ORCPT ); Wed, 6 Apr 2022 14:03:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240625AbiDFSDT (ORCPT ); Wed, 6 Apr 2022 14:03:19 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97A561B72EF for ; Wed, 6 Apr 2022 09:38:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fZlzg3VGO4pQkvRdEjwxmOLtpBF/+tX3tGinhcLBFPg=; b=azmW2hQ95N/1lpLgDq8Iom2Ziz DIe0hnewEc5ijlYVd+icT2IOkuhQDRmU5jOu7EZm7nY8gOLygWyBHv2eNMw39kSa+Kz0VBgNvN6b9 dffL9rknVuW8aOlvwHKGM9JC+SNAYjdjZebHgcNz4q6L8EKsaRgyaN0/nRdKA83vk92ENGdsolcoU dj8P+pvTMrlfDRNetGbjT6V85z9fp+VoWPOiYPLoaDZCG3O0VwyNrylto4hvUz4fTxCTXptJ/N7YE MNk+0wC9k5UrQKFKck/VUR4KXc7H5bErJx9jaZmTMPE2jLa1aSngy3MCQO38w87rszGPfwDb6x08W zZSc3y0g==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nc8fg-007DuT-87; Wed, 06 Apr 2022 16:38:16 +0000 Date: Wed, 6 Apr 2022 09:38:16 -0700 From: Christoph Hellwig To: Andrey Albershteyn Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 4/5] xfs_quota: utilize XFS_GETNEXTQUOTA for ranged calls in report/dump Message-ID: References: <20220328222503.146496-1-aalbersh@redhat.com> <20220328222503.146496-5-aalbersh@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220328222503.146496-5-aalbersh@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org > + while (get_quota(&d, id, &oid, type, > + mount->fs_name, flags|GETNEXTQUOTA_FLAG) && space around the operator please. The changes themselves look fine to me: Reviewed-by: Christoph Hellwig