From: Petr Mladek <pmladek@suse.com>
To: Jonathan Lassoff <jof@thejof.com>
Cc: linux-xfs@vger.kernel.org, "Darrick J. Wong" <djwong@kernel.org>,
Dave Chinner <david@fromorbit.com>,
Chris Down <chris@chrisdown.name>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
John Ogness <john.ogness@linutronix.de>
Subject: Re: [PATCH v3 1/2] Simplify XFS logging methods.
Date: Tue, 29 Mar 2022 15:03:56 +0200 [thread overview]
Message-ID: <YkMDvMy0QOg2mo99@alley> (raw)
In-Reply-To: <3e1f6011b22ca87ea3c0fad701286369daa2187f.1648228733.git.jof@thejof.com>
On Fri 2022-03-25 10:19:45, Jonathan Lassoff wrote:
> Rather than have a constructor to define many nearly-identical
> functions, use preprocessor macros to pass down a kernel logging level
> to a common function.
>
> diff --git a/fs/xfs/xfs_message.h b/fs/xfs/xfs_message.h
> index bb9860ec9a93..2f609800e806 100644
> --- a/fs/xfs/xfs_message.h
> +++ b/fs/xfs/xfs_message.h
> @@ -6,33 +6,36 @@
> -void xfs_debug(const struct xfs_mount *mp, const char *fmt, ...)
> -{
> -}
> +#define xfs_debug(mp, fmt, ...) do {} while (0)
> #endif
>
> +extern __printf(3, 4)
> +void xfs_alert_tag(const struct xfs_mount *mp, int tag, const char *fmt, ...);
The trend is to avoid "extern" because it just creates noise. Well, I
am not sure what are the preferences in the XFS code.
Otherwise the changes look fine to me. Feel free to use:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2022-03-29 13:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 17:19 [PATCH v3 1/2] Simplify XFS logging methods Jonathan Lassoff
2022-03-25 17:19 ` [PATCH v3 2/2] Add XFS messages to printk index Jonathan Lassoff
2022-03-29 13:34 ` Petr Mladek
2022-03-30 0:34 ` Dave Chinner
2022-03-30 0:46 ` Darrick J. Wong
2022-03-30 1:26 ` Dave Chinner
2022-03-30 14:59 ` Petr Mladek
2022-03-30 15:07 ` Chris Down
2022-03-31 15:06 ` Darrick J. Wong
2022-04-05 12:55 ` Petr Mladek
2022-03-31 9:14 ` Sergey Senozhatsky
2022-03-30 11:52 ` Chris Down
2022-03-30 16:47 ` Steven Rostedt
2022-03-30 17:09 ` Chris Down
2022-03-30 17:25 ` Chris Down
2022-03-30 17:39 ` Steven Rostedt
2022-03-30 17:44 ` Chris Down
2022-03-30 21:02 ` Dave Chinner
2022-03-31 14:09 ` Petr Mladek
2022-04-01 21:50 ` Dave Chinner
2022-03-30 12:05 ` Chris Down
2022-03-30 0:05 ` Dave Chinner
2022-03-30 12:07 ` Chris Down
2022-03-31 1:38 ` Jonathan Lassoff
2022-03-29 13:03 ` Petr Mladek [this message]
2022-03-29 23:54 ` [PATCH v3 1/2] Simplify XFS logging methods Dave Chinner
2022-03-30 11:40 ` Petr Mladek
2022-03-30 11:55 ` Chris Down
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkMDvMy0QOg2mo99@alley \
--to=pmladek@suse.com \
--cc=chris@chrisdown.name \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=jof@thejof.com \
--cc=john.ogness@linutronix.de \
--cc=linux-xfs@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox