linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Down <chris@chrisdown.name>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Dave Chinner <david@fromorbit.com>,
	Petr Mladek <pmladek@suse.com>, Jonathan Lassoff <jof@thejof.com>,
	linux-xfs@vger.kernel.org, "Darrick J. Wong" <djwong@kernel.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	John Ogness <john.ogness@linutronix.de>
Subject: Re: [PATCH v3 2/2] Add XFS messages to printk index
Date: Wed, 30 Mar 2022 18:09:28 +0100	[thread overview]
Message-ID: <YkSOyC+vEMVSDsdU@chrisdown.name> (raw)
In-Reply-To: <20220330124739.70edca36@gandalf.local.home>

Steven Rostedt writes:
>On Wed, 30 Mar 2022 12:52:58 +0100
>Chris Down <chris@chrisdown.name> wrote:
>
>> The policy, as with all debugfs APIs by default, is that it's completely
>> unstable and there are no API stability guarantees whatsoever. That's why
>> there's no extensive documentation for users: because this is a feature for
>> kernel developers.
>>
>> 0: https://lwn.net/Articles/309298/
>
>That article you reference states the opposite of what you said. And I got
>burnt by it before. Because Linus stated, if it is available for users, it
>is an ABI.

Hmm, even in 2011 after that article there were discussions about debugfs 
explicitly being the "wild west"[0], no? I heard the same during LSFMM 
discussions during recent years as well. Although I confess that I am not 
frequently in discussions about debugfs so I don't really know where the 
majority opinion is nowadays.

Either way, as discussed the contents wouldn't be the ABI (as with my 
/proc/self/smaps allusion), the file format would be, so it wouldn't imply that 
printk() calls themselves or their locations become an ABI.

0: https://lwn.net/Articles/429321/

  reply	other threads:[~2022-03-30 17:09 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-25 17:19 [PATCH v3 1/2] Simplify XFS logging methods Jonathan Lassoff
2022-03-25 17:19 ` [PATCH v3 2/2] Add XFS messages to printk index Jonathan Lassoff
2022-03-29 13:34   ` Petr Mladek
2022-03-30  0:34     ` Dave Chinner
2022-03-30  0:46       ` Darrick J. Wong
2022-03-30  1:26         ` Dave Chinner
2022-03-30 14:59           ` Petr Mladek
2022-03-30 15:07             ` Chris Down
2022-03-31 15:06               ` Darrick J. Wong
2022-04-05 12:55                 ` Petr Mladek
2022-03-31  9:14             ` Sergey Senozhatsky
2022-03-30 11:52       ` Chris Down
2022-03-30 16:47         ` Steven Rostedt
2022-03-30 17:09           ` Chris Down [this message]
2022-03-30 17:25             ` Chris Down
2022-03-30 17:39             ` Steven Rostedt
2022-03-30 17:44               ` Chris Down
2022-03-30 21:02           ` Dave Chinner
2022-03-31 14:09             ` Petr Mladek
2022-04-01 21:50               ` Dave Chinner
2022-03-30 12:05     ` Chris Down
2022-03-30  0:05   ` Dave Chinner
2022-03-30 12:07   ` Chris Down
2022-03-31  1:38     ` Jonathan Lassoff
2022-03-29 13:03 ` [PATCH v3 1/2] Simplify XFS logging methods Petr Mladek
2022-03-29 23:54 ` Dave Chinner
2022-03-30 11:40   ` Petr Mladek
2022-03-30 11:55 ` Chris Down

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkSOyC+vEMVSDsdU@chrisdown.name \
    --to=chris@chrisdown.name \
    --cc=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=jof@thejof.com \
    --cc=john.ogness@linutronix.de \
    --cc=linux-xfs@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).