From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 894BAC433EF for ; Tue, 10 May 2022 12:52:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242070AbiEJMzy (ORCPT ); Tue, 10 May 2022 08:55:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242088AbiEJMzq (ORCPT ); Tue, 10 May 2022 08:55:46 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB5494EA30 for ; Tue, 10 May 2022 05:51:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TqucSDq5l7oH4GKXy9WV0ZkIHqd4+Zrobts4YX8Pt/I=; b=3lMwIT8dP2w/fgiip2bTPhZBPD XDIZxKtzpsGSAvVx9FBDduhCnKNDs1n7jArXLb+NyvpDJIlRfRULI7Cp/vjAGeRpm+2zQFc274n6i MuQ8FXfMx3DwRPOalHFx+ayUNaMJe33eHejLQyOeH1S5pOm9utsxWJG4ipD4X4nXdsXYNSJP+jqvU 4Q6BUD6bbbRoyZ6zu2STleIdJi+CvNVf51L5k4dOMXO5N9QbqdXqeA7u3zQf5dyvETGVfpLPDgphN pPOjCKIkNWsBTIlMYyw8bPZwfXIXSpjSUO72btNPby0TiKveN1bqwvkztihFjVHFPAWporDKMPY0m q9g4pM3g==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1noPKX-0020xI-1u; Tue, 10 May 2022 12:51:09 +0000 Date: Tue, 10 May 2022 05:51:08 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/4] xfs_repair: fix sizing of the incore rt space usage map calculation Message-ID: References: <165176668306.247207.13169734586973190904.stgit@magnolia> <165176668866.247207.345273533440446216.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <165176668866.247207.345273533440446216.stgit@magnolia> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, May 05, 2022 at 09:04:48AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > If someone creates a realtime volume exactly *one* extent in length, the > sizing calculation for the incore rt space usage bitmap will be zero > because the integer division here rounds down. Use howmany() to round > up. Note that there can't be that many single-extent rt volumes since > repair will corrupt them into zero-extent rt volumes, and we haven't > gotten any reports. Looks good: Reviewed-by: Christoph Hellwig