linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Zorro Lang <zlang@redhat.com>, Eryu Guan <guaneryu@gmail.com>
Cc: fstests <fstests@vger.kernel.org>, xfs <linux-xfs@vger.kernel.org>
Subject: [PATCH] xfs/545: check for fallocate support before running test
Date: Tue, 24 May 2022 12:52:19 -0700	[thread overview]
Message-ID: <Yo03czi2EzyKy2/c@magnolia> (raw)

From: Darrick J. Wong <djwong@kernel.org>

This test fails when alwayscow mode is enabled:

--- xfs/545.out
+++ xfs/545.out.bad
@@ -1,4 +1,5 @@
 QA output created by 545
+fallocate: Operation not supported
 Creating directory system to dump using fsstress.

Fix this by checking for fallocate support first.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 tests/xfs/545 |    1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/xfs/545 b/tests/xfs/545
index e3dd300a..dfe2f2dc 100755
--- a/tests/xfs/545
+++ b/tests/xfs/545
@@ -14,6 +14,7 @@ _begin_fstest auto quick dump
 . ./common/dump
 
 _supported_fs xfs
+_require_xfs_io_command "falloc"
 _require_scratch
 
 # A large stripe unit will put the root inode out quite far

             reply	other threads:[~2022-05-24 19:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-24 19:52 Darrick J. Wong [this message]
2022-05-24 23:48 ` [PATCH] xfs/545: check for fallocate support before running test Dave Chinner
2022-05-27  6:18 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yo03czi2EzyKy2/c@magnolia \
    --to=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).