* [PATCH] xfs: Remove duplicate include
@ 2022-05-15 13:11 Jiapeng Chong
2022-05-15 19:25 ` Darrick J. Wong
0 siblings, 1 reply; 4+ messages in thread
From: Jiapeng Chong @ 2022-05-15 13:11 UTC (permalink / raw)
To: djwong; +Cc: linux-xfs, linux-kernel, Jiapeng Chong, Abaci Robot
Clean up the following includecheck warning:
./fs/xfs/xfs_attr_item.c: xfs_inode.h is included more than once.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
fs/xfs/xfs_attr_item.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/xfs/xfs_attr_item.c b/fs/xfs/xfs_attr_item.c
index e8ac88d9fd14..bf9a01b083b8 100644
--- a/fs/xfs/xfs_attr_item.c
+++ b/fs/xfs/xfs_attr_item.c
@@ -22,7 +22,6 @@
#include "xfs_attr.h"
#include "xfs_attr_item.h"
#include "xfs_trace.h"
-#include "xfs_inode.h"
#include "xfs_trans_space.h"
#include "xfs_errortag.h"
#include "xfs_error.h"
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: Remove duplicate include
2022-05-15 13:11 [PATCH] xfs: Remove duplicate include Jiapeng Chong
@ 2022-05-15 19:25 ` Darrick J. Wong
0 siblings, 0 replies; 4+ messages in thread
From: Darrick J. Wong @ 2022-05-15 19:25 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: linux-xfs, linux-kernel, Abaci Robot
On Sun, May 15, 2022 at 09:11:40PM +0800, Jiapeng Chong wrote:
> Clean up the following includecheck warning:
>
> ./fs/xfs/xfs_attr_item.c: xfs_inode.h is included more than once.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
LGTM
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_attr_item.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_attr_item.c b/fs/xfs/xfs_attr_item.c
> index e8ac88d9fd14..bf9a01b083b8 100644
> --- a/fs/xfs/xfs_attr_item.c
> +++ b/fs/xfs/xfs_attr_item.c
> @@ -22,7 +22,6 @@
> #include "xfs_attr.h"
> #include "xfs_attr_item.h"
> #include "xfs_trace.h"
> -#include "xfs_inode.h"
> #include "xfs_trans_space.h"
> #include "xfs_errortag.h"
> #include "xfs_error.h"
> --
> 2.20.1.7.g153144c
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] xfs: Remove duplicate include
@ 2023-08-24 7:47 Jiapeng Chong
2023-08-24 16:13 ` Darrick J. Wong
0 siblings, 1 reply; 4+ messages in thread
From: Jiapeng Chong @ 2023-08-24 7:47 UTC (permalink / raw)
To: chandan.babu; +Cc: djwong, linux-xfs, linux-kernel, Jiapeng Chong, Abaci Robot
./fs/xfs/scrub/xfile.c: xfs_format.h is included more than once.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6209
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
fs/xfs/scrub/xfile.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/xfs/scrub/xfile.c b/fs/xfs/scrub/xfile.c
index d98e8e77c684..090c3ead43fd 100644
--- a/fs/xfs/scrub/xfile.c
+++ b/fs/xfs/scrub/xfile.c
@@ -10,7 +10,6 @@
#include "xfs_log_format.h"
#include "xfs_trans_resv.h"
#include "xfs_mount.h"
-#include "xfs_format.h"
#include "scrub/xfile.h"
#include "scrub/xfarray.h"
#include "scrub/scrub.h"
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: Remove duplicate include
2023-08-24 7:47 Jiapeng Chong
@ 2023-08-24 16:13 ` Darrick J. Wong
0 siblings, 0 replies; 4+ messages in thread
From: Darrick J. Wong @ 2023-08-24 16:13 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: chandan.babu, linux-xfs, linux-kernel, Abaci Robot
On Thu, Aug 24, 2023 at 03:47:23PM +0800, Jiapeng Chong wrote:
> ./fs/xfs/scrub/xfile.c: xfs_format.h is included more than once.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6209
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/scrub/xfile.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/scrub/xfile.c b/fs/xfs/scrub/xfile.c
> index d98e8e77c684..090c3ead43fd 100644
> --- a/fs/xfs/scrub/xfile.c
> +++ b/fs/xfs/scrub/xfile.c
> @@ -10,7 +10,6 @@
> #include "xfs_log_format.h"
> #include "xfs_trans_resv.h"
> #include "xfs_mount.h"
> -#include "xfs_format.h"
> #include "scrub/xfile.h"
> #include "scrub/xfarray.h"
> #include "scrub/scrub.h"
> --
> 2.20.1.7.g153144c
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-24 16:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-15 13:11 [PATCH] xfs: Remove duplicate include Jiapeng Chong
2022-05-15 19:25 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2023-08-24 7:47 Jiapeng Chong
2023-08-24 16:13 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox