From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46F4FC433F5 for ; Mon, 16 May 2022 13:43:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229554AbiEPNnt (ORCPT ); Mon, 16 May 2022 09:43:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230398AbiEPNnt (ORCPT ); Mon, 16 May 2022 09:43:49 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BA6935879; Mon, 16 May 2022 06:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bdKEgcBu660QK59Q7ijUEpupyYvQqpjvn1VWbciI8qw=; b=O/SokAB18zhm+omASVU0WcYHV4 pBaIDuyPT8BdWj0IvU5nAl7VHstuV4EgY3Na29XZ6YIeAtQoFfctGmHpInbBc9MO3G8vJQAFGkONP 5z92l/5uDZ3B3e2zRs5Yagnhi8Sbk5DXTZ9OfERsyNy9w37eBeB9GDoz06oT0HRLJKrgEhBu7QW1m naIVgpg0nPy/xS2SAVFzYZwkh9E7x/JcTd41TLtxaNEPsTvD36+CezTZNZOPGgbyqcovB9W4jCYJ3 6cFzR3Q0u6I7u6JJg7NdCA9nK11udjZO5NKGD7tQ0Gou3ySkStzUmesg8Oz2mypgTU0WYSWNjJeOi j2yXTD/g==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqb0h-0081X1-86; Mon, 16 May 2022 13:43:43 +0000 Date: Mon, 16 May 2022 06:43:43 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Dave Chinner , Matthew Wilcox , linux-fsdevel , xfs , Christoph Hellwig Subject: Re: [PATCH] iomap: don't invalidate folios after writeback errors Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org The changes looks good to me: Reviewed-by: Christoph Hellwig I did a little digging and the invalidatepage call first appeared in commit 90ce6b6a90f62578a141359ffe9261e65f2c5265 Author: Steve Lord Date: Mon Sep 2 12:36:59 2002 +0000 move page_buf_io.c to xfs_aops.c The old page_buf_io.c file seems to not have made it through to git, so this seems rather prehistoric.