From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org, david@fromorbit.com
Subject: Re: [PATCH 3/3] xfs: convert buf_cancel_table allocation to kmalloc_array
Date: Thu, 19 May 2022 10:08:44 -0700 [thread overview]
Message-ID: <YoZ5nFI7fNSmFYCB@magnolia> (raw)
In-Reply-To: <YoYBqe1I5fjl9Dfl@infradead.org>
On Thu, May 19, 2022 at 01:36:57AM -0700, Christoph Hellwig wrote:
> On Wed, May 18, 2022 at 11:55:40AM -0700, Darrick J. Wong wrote:
> > + p = kmalloc_array(XLOG_BC_TABLE_SIZE, sizeof(struct list_head),
> > + GFP_KERNEL | __GFP_NOWARN);
>
> Why the __GFP_NOWARN?
It's a straight port of xfs_km_flags_t==0, which is what the old code
did. I suspect it doesn't make any practical difference since at most
this will be allocating 1k of memory. Want me to make it GFP_KERNEL
only?
--D
next prev parent reply other threads:[~2022-05-19 17:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 18:55 [PATCHSET 0/3] xfs: fix buffer cancellation table leak during log recovery Darrick J. Wong
2022-05-18 18:55 ` [PATCH 1/3] xfs: refactor buffer cancellation table allocation Darrick J. Wong
2022-05-19 8:35 ` Christoph Hellwig
2022-05-19 18:01 ` Darrick J. Wong
2022-05-18 18:55 ` [PATCH 2/3] xfs: don't leak xfs_buf_cancel structures when recovery fails Darrick J. Wong
2022-05-19 8:36 ` Christoph Hellwig
2022-05-18 18:55 ` [PATCH 3/3] xfs: convert buf_cancel_table allocation to kmalloc_array Darrick J. Wong
2022-05-19 8:36 ` Christoph Hellwig
2022-05-19 17:08 ` Darrick J. Wong [this message]
2022-05-19 17:29 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2022-05-24 5:35 [PATCHSET v2 0/3] xfs: fix buffer cancellation table leak during log recovery Darrick J. Wong
2022-05-24 5:36 ` [PATCH 3/3] xfs: convert buf_cancel_table allocation to kmalloc_array Darrick J. Wong
2022-05-27 1:25 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoZ5nFI7fNSmFYCB@magnolia \
--to=djwong@kernel.org \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).