From: Christoph Hellwig <hch@infradead.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Eric Biggers <ebiggers@kernel.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-block@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] f2fs: add sysfs entry to avoid FUA
Date: Fri, 27 May 2022 22:03:10 -0700 [thread overview]
Message-ID: <YpGtDhV7V7gDk430@infradead.org> (raw)
In-Reply-To: <YpF1gPrQY3UFsgwC@google.com>
On Fri, May 27, 2022 at 06:06:08PM -0700, Jaegeuk Kim wrote:
> I think there's still some benefit to use FUA such as small chunk writes
> for checkpoint.
Did you measure if there is? Because some SSDs basically implemented
FUA as an implied flush after the write, in which case it would not
really help there either (but also not hurt).
But as the previous two maintainers already said - this needs quirking
at the driver layer, not in the submitter.
next prev parent reply other threads:[~2022-05-28 5:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220527205955.3251982-1-jaegeuk@kernel.org>
2022-05-27 21:33 ` [PATCH] f2fs: add sysfs entry to avoid FUA Eric Biggers
2022-05-27 23:55 ` Dave Chinner
2022-05-28 0:26 ` Jaegeuk Kim
2022-05-28 5:12 ` Dave Chinner
2022-05-28 1:06 ` Jaegeuk Kim
2022-05-28 1:42 ` Darrick J. Wong
2022-05-28 5:03 ` Christoph Hellwig [this message]
2022-05-31 20:15 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpGtDhV7V7gDk430@infradead.org \
--to=hch@infradead.org \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).