From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79E9CC433EF for ; Thu, 16 Jun 2022 07:34:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359470AbiFPHek (ORCPT ); Thu, 16 Jun 2022 03:34:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359475AbiFPHek (ORCPT ); Thu, 16 Jun 2022 03:34:40 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F132D2AF8 for ; Thu, 16 Jun 2022 00:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=K55oIf/F1kWjV4RMkt9iosw7Tu0Fjsgyu2HoNzCXp9s=; b=wgIFeCbQdJNZYT4ckE0gFcpjMp yMHrY+7UsPWkIVEAEpFzAOiONEaaVVL5apCHYuM4oz9E5YDGEtLeHvuX+1m65n4ia7nVLzhZD/DB4 lDSXKdNndDlCHMYzfHW28OmDvrOCtNVTor+5M5i4KWJvfvE2YycTaPtyp4EgaGmGaZpU3y35zayaw okqnHkJ+r/7HBTpNZd6wANNvuiKlpy5zAm5cQkRabEkhLEuojrUGv4SwB7zwmbbWX5mt055T7QR03 KeVKONRudMYzkuhmHhOcT+opWPaRDkj2x0xuxoL99B/NhdhQrr/2tBAGbYxsfPOpn2KHid3mcKMud kC8YmAhQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1k1W-00150x-Km; Thu, 16 Jun 2022 07:34:38 +0000 Date: Thu, 16 Jun 2022 00:34:38 -0700 From: Christoph Hellwig To: Dave Chinner Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 03/50] xfs: pass perag to xfs_ialloc_read_agi() Message-ID: References: <20220611012659.3418072-1-david@fromorbit.com> <20220611012659.3418072-4-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220611012659.3418072-4-david@fromorbit.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Sat, Jun 11, 2022 at 11:26:12AM +1000, Dave Chinner wrote: > @@ -833,7 +835,7 @@ xfs_ag_shrink_space( > xfs_trans_bhold(*tpp, agfbp); > err2 = xfs_trans_roll(tpp); > if (err2) > - return err2; > + return error; > xfs_trans_bjoin(*tpp, agfbp); > goto resv_init_out; > } This change looks unrelated and is undocumented. Otherwise looks good: Reviewed-by: Christoph Hellwig