Re: [RFC] [PATCH 00/50] xfs: per-ag centric allocation alogrithms

Dave Chinner
2022-06-21T02:08:21Z

On Thu, Jun 16, 2022 at 05:01:40AM -0700, Christoph Hellwig wrote:
> On Sat, Jun 11, 2022 at 11:26:09AM +1000, Dave Chinner wrote:
> >
> > This series starts by driving the perag down into the AGI, AGF and
> > AGFL access routines and unifies the perag structure initialisation
> > with the high level AG header read functions. This largely replaces
> > the xfs_mount/agno pair that is passed to all these functions with a
> > perag, and in most places we already have a perag ready to pass in.
>
> Btw, one neat thing would be versions of helpers like XFS_AG_DADDR
> and XFS_AGB_TO_FSB that take the pag structure instead of the mp/agno
> pair.

*nod*

Yeah, that's something I'm trying to work towards by driving more
geometry information into the perag. I haven't tried to do the
bigger conversions yet because the perag isn't widely used enough
yet, and it's likely that there will be additional complexities with
the userspace code I haven't realised yet. Getting the allocation
code to pass around referenced perags is a big part of getting
there, but there's still plenty more to do before I think I'll be
able to tackle cleaning up the many unit conversion macros we have.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com