From: Leah Rumancik <leah.rumancik@gmail.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>
Subject: Re: [5.15] MAINTAINERS: add Leah as xfs maintainer for 5.15.y
Date: Thu, 30 Jun 2022 10:42:12 -0700 [thread overview]
Message-ID: <Yr3gdLPU2SDJzPtf@google.com> (raw)
In-Reply-To: <CAOQ4uxh-2c0Sp=nUN-brB3ySb_rhYPLPa-VxJW9WOzSXOLUCww@mail.gmail.com>
On Thu, Jun 30, 2022 at 08:31:03AM +0300, Amir Goldstein wrote:
> On Thu, Jun 30, 2022 at 3:11 AM Leah Rumancik <leah.rumancik@gmail.com> wrote:
> >
> > Update MAINTAINERS for xfs in an effort to help direct bots/questions
> > about xfs in 5.15.y.
> >
> > Note: 5.10.y [1] and 5.4.y will have different updates to their
> > respective MAINTAINERS files for this effort.
> >
> > Suggested-by: Darrick J. Wong <djwong@kernel.org>
> > Signed-off-by: Leah Rumancik <leah.rumancik@gmail.com>
> >
> > [1] https://lore.kernel.org/linux-xfs/20220629213236.495647-1-amir73il@gmail.com/
>
> It is not good practice to put stuff after the commit message trailer.
> Greg's signature is going to be after that line.
> In this case, I think you could simply drop the [1] reference
> it's not important in git historic perspective.
>
> You could add the references after --- if you like.
Sure, that makes sense. Thanks for pointing this out.
- Leah
>
> Thanks,
> Amir.
>
> > ---
> > MAINTAINERS | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 393706e85ba2..a60d7e0466af 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -20579,6 +20579,7 @@ F: drivers/xen/*swiotlb*
> >
> > XFS FILESYSTEM
> > C: irc://irc.oftc.net/xfs
> > +M: Leah Rumancik <leah.rumancik@gmail.com>
> > M: Darrick J. Wong <djwong@kernel.org>
> > M: linux-xfs@vger.kernel.org
> > L: linux-xfs@vger.kernel.org
> > --
> > 2.37.0.rc0.161.g10f37bed90-goog
> >
next prev parent reply other threads:[~2022-06-30 17:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 23:55 [5.15] MAINTAINERS: add Leah as xfs maintainer for 5.15.y Leah Rumancik
2022-06-30 0:40 ` Darrick J. Wong
2022-06-30 5:31 ` Amir Goldstein
2022-06-30 17:42 ` Leah Rumancik [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-06-30 20:52 Leah Rumancik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr3gdLPU2SDJzPtf@google.com \
--to=leah.rumancik@gmail.com \
--cc=amir73il@gmail.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).