From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4B22C433EF for ; Wed, 29 Jun 2022 07:07:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231773AbiF2HG7 (ORCPT ); Wed, 29 Jun 2022 03:06:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232992AbiF2HGh (ORCPT ); Wed, 29 Jun 2022 03:06:37 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68ED2632E for ; Wed, 29 Jun 2022 00:05:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=iiUp6+87gjd3DrItlyCzA2H9VwVJvqYk3jH2qaHKScU=; b=PqGx5aCpqv2Gj3o51ioauelIiv 3+GE9TAIfNLJgDr0z8Svl5daUywJbEdJbV8Tu+jwU+JRxMM3Z0ZHpfJ1LPz7sWi4pr+gtswIJnjHo pn98ukPr4Rf3dMhETFFg7SZgomKeaTlLwAYdJE3yVi0Re8EjW2AAQlrqMruKiMLl0915WfI7SfW5L vMQ9wGgdCwLrRLGVolJWE0PhVTZR7dL8AwSpnCiC0P6mas/VIrvPqwNer0jAc+pnPxWZIErA0ClDB uDShInt+71/7ZVg1VE65NPGS+Hp8pnSkgV0Qa4EBuejqOMy2kkgJLIfHvAg7NXZ1M45PvHk1mK6qx A8aAwh+g==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6RlT-009zaj-QO; Wed, 29 Jun 2022 07:05:31 +0000 Date: Wed, 29 Jun 2022 00:05:31 -0700 From: Christoph Hellwig To: Dave Chinner Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/9] xfs: factor the xfs_iunlink functions Message-ID: References: <20220627004336.217366-1-david@fromorbit.com> <20220627004336.217366-2-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220627004336.217366-2-david@fromorbit.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org > +xfs_iunlink_insert_inode( > struct xfs_trans *tp, > + struct xfs_perag *pag, > + struct xfs_buf *agibp, > struct xfs_inode *ip) > -{ > + { Whitespace damage here. Otherwise looks good: Reviewed-by: Christoph Hellwig