public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Dave Chinner <david@fromorbit.com>,
	Ayushman Dutta <ayushman999@gmail.com>,
	Chandan Rajendra <chandanrlinux@gmail.com>,
	linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: syzkaller@googlegroups.com
Date: Wed, 29 Jun 2022 09:17:03 -0700	[thread overview]
Message-ID: <Yrx6/0UmYyuBPjEr@magnolia> (raw)
In-Reply-To: <CAOQ4uxiWBMZSy9R9KNFKf5ptqM38naaSS5vLY2hdbYLvT0L5VA@mail.gmail.com>

On Wed, Jun 29, 2022 at 07:32:43AM +0300, Amir Goldstein wrote:
> On Wed, Jun 29, 2022 at 1:52 AM Dave Chinner <david@fromorbit.com> wrote:
> >
> > On Tue, Jun 28, 2022 at 03:07:51PM -0700, Darrick J. Wong wrote:
> > > [+linux-xfs]
> > >
> > > On Tue, Jun 28, 2022 at 02:27:36PM -0500, Ayushman Dutta wrote:
> > > > Kernel Version: 5.10.122
> > > >
> > > > Kernel revision: 58a0d94cb56fe0982aa1ce9712e8107d3a2257fe
> > > >
> > > > Syzkaller Dashboard report:
> > > >
> > > > ------------[ cut here ]------------
> > > > WARNING: CPU: 1 PID: 8503 at mm/util.c:618 kvmalloc_node+0x15a/0x170
> > > > mm/util.c:618
> > >
> > > No.  Do not DM your syzbot reports to random XFS developers.
> > >
> > > Especially do not send me *three message* with 300K of attachments; even
> > > the regular syzbot runners dump all that stuff into a web portal.
> > >
> > > If you are going to run some scripted tool to randomly
> > > corrupt the filesystem to find failures, then you have an
> > > ethical and moral responsibility to do some of the work to
> > > narrow down and identify the cause of the failure, not just
> > > throw them at someone else to do all the work.
> >
> > /me reads the stack trace, takes 30s to look at the change log,
> > finds commit 29d650f7e3ab ("xfs: reject crazy array sizes being fed
> > to XFS_IOC_GETBMAP*").
> >
> 
> I don't have the syzbot link here, but I assume this is reproducible
> and not reproducing on mainline, so in fact syzbot should be capable
> of finding the fix commit itself.
> 
> If syzbot can hear me, next time you find an xfs bug that is reproducible
> on 5.10.y and not on mainline, you may send it to me.

I suspect this guy is /not/ affiliated with the actual googlers who run
syzbot internally, which is why there's no link to their web app.

> Darrick, if you want to find a creative way to encode that request
> in MAINTAINERS as you suggested, that is fine by me.
> It should be something that makes it easy to teach the few bots that run
> on LTS kernels to find the right recipients and spam us instead of you.
> We could add a P: Subsystem Profile document, which contains stable
> maintainers info but that is less robot friendly.
> I don't have a better idea.

Yeah, I'll email the rest of the xfs lts cabal about that.

> This fix patch is in my xfs-5.10.y queue - it will probably take several
> weeks/month until it gets reviewed. I could expedite it if anyone
> feels that I should.

I don't care, but the people who think that /any/ backtrace in dmesg
might, even though this one in particular logs the warning and returns
ENOMEM.

--D

> Thanks,
> Amir.

      reply	other threads:[~2022-06-29 16:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CA+6OtaVMKW=K2mfbi=3A7fuPw2BmHv-zcx2jVKg9yEEY4wab3g@mail.gmail.com>
2022-06-28 22:07 ` syzkaller@googlegroups.com Darrick J. Wong
2022-06-28 22:44   ` syzkaller@googlegroups.com Dave Chinner
2022-06-29  4:32     ` syzkaller@googlegroups.com Amir Goldstein
2022-06-29 16:17       ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yrx6/0UmYyuBPjEr@magnolia \
    --to=djwong@kernel.org \
    --cc=amir73il@gmail.com \
    --cc=ayushman999@gmail.com \
    --cc=chandanrlinux@gmail.com \
    --cc=david@fromorbit.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox