From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/6] xfs: merge xfs_buf_find() and xfs_buf_get_map()
Date: Sun, 10 Jul 2022 22:14:16 -0700 [thread overview]
Message-ID: <YsuxqAoM0IWD7CaE@infradead.org> (raw)
In-Reply-To: <20220707235259.1097443-4-david@fromorbit.com>
On Fri, Jul 08, 2022 at 09:52:56AM +1000, Dave Chinner wrote:
> index 91dc691f40a8..81ca951b451a 100644
> --- a/fs/xfs/xfs_buf.c
> +++ b/fs/xfs/xfs_buf.c
> @@ -531,18 +531,16 @@ xfs_buf_map_verify(
>
> static int
> xfs_buf_find_lock(
> - struct xfs_buftarg *btp,
> struct xfs_buf *bp,
> xfs_buf_flags_t flags)
> {
> if (!xfs_buf_trylock(bp)) {
> if (flags & XBF_TRYLOCK) {
> - xfs_buf_rele(bp);
> - XFS_STATS_INC(btp->bt_mount, xb_busy_locked);
> + XFS_STATS_INC(bp->b_mount, xb_busy_locked);
> return -EAGAIN;
> }
> xfs_buf_lock(bp);
> - XFS_STATS_INC(btp->bt_mount, xb_get_locked_waited);
> + XFS_STATS_INC(bp->b_mount, xb_get_locked_waited);
> }
>
> /*
Not doing this to start with in the previous patch still feels
rather odd.
next prev parent reply other threads:[~2022-07-11 5:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 23:52 [PATCH 0/6 v3] xfs: lockless buffer lookups Dave Chinner
2022-07-07 23:52 ` [PATCH 1/6] xfs: rework xfs_buf_incore() API Dave Chinner
2022-07-07 23:52 ` [PATCH 2/6] xfs: break up xfs_buf_find() into individual pieces Dave Chinner
2022-07-09 22:58 ` Darrick J. Wong
2022-07-07 23:52 ` [PATCH 3/6] xfs: merge xfs_buf_find() and xfs_buf_get_map() Dave Chinner
2022-07-10 0:15 ` Darrick J. Wong
2022-07-11 5:14 ` Christoph Hellwig [this message]
2022-07-12 0:01 ` Dave Chinner
2022-07-07 23:52 ` [PATCH 4/6] xfs: reduce the number of atomic when locking a buffer after lookup Dave Chinner
2022-07-07 23:52 ` [PATCH 5/6] xfs: remove a superflous hash lookup when inserting new buffers Dave Chinner
2022-07-07 23:52 ` [PATCH 6/6] xfs: lockless buffer lookup Dave Chinner
2022-07-10 0:15 ` Darrick J. Wong
2022-07-13 17:01 ` [PATCH 0/6 v3] xfs: lockless buffer lookups Darrick J. Wong
2022-07-13 17:03 ` Darrick J. Wong
2022-07-14 1:32 ` Dave Chinner
2022-07-14 2:11 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2022-06-27 6:08 [PATCH 0/6 v2] " Dave Chinner
2022-06-27 6:08 ` [PATCH 3/6] xfs: merge xfs_buf_find() and xfs_buf_get_map() Dave Chinner
2022-06-29 7:40 ` Christoph Hellwig
2022-06-29 22:06 ` Darrick J. Wong
2022-07-07 12:39 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsuxqAoM0IWD7CaE@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox