* [PATCH] xfs: delete unnecessary NULL checks
@ 2022-07-18 11:21 Dan Carpenter
2022-07-18 17:16 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-07-18 11:21 UTC (permalink / raw)
To: Darrick J. Wong
Cc: Dave Chinner, Chandan Babu R, Allison Henderson, linux-xfs,
kernel-janitors
These NULL check are no long needed after commit 2ed5b09b3e8f ("xfs:
make inode attribute forks a permanent part of struct xfs_inode").
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
fs/xfs/libxfs/xfs_inode_fork.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/xfs/libxfs/xfs_inode_fork.c b/fs/xfs/libxfs/xfs_inode_fork.c
index 7c34184448e6..fa699f3792bf 100644
--- a/fs/xfs/libxfs/xfs_inode_fork.c
+++ b/fs/xfs/libxfs/xfs_inode_fork.c
@@ -724,8 +724,7 @@ xfs_ifork_verify_local_attr(
if (fa) {
xfs_inode_verifier_error(ip, -EFSCORRUPTED, "attr fork",
- ifp ? ifp->if_u1.if_data : NULL,
- ifp ? ifp->if_bytes : 0, fa);
+ ifp->if_u1.if_data, ifp->if_bytes, fa);
return -EFSCORRUPTED;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] xfs: delete unnecessary NULL checks
2022-07-18 11:21 [PATCH] xfs: delete unnecessary NULL checks Dan Carpenter
@ 2022-07-18 17:16 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2022-07-18 17:16 UTC (permalink / raw)
To: Dan Carpenter
Cc: Dave Chinner, Chandan Babu R, Allison Henderson, linux-xfs,
kernel-janitors
On Mon, Jul 18, 2022 at 02:21:30PM +0300, Dan Carpenter wrote:
> These NULL check are no long needed after commit 2ed5b09b3e8f ("xfs:
> make inode attribute forks a permanent part of struct xfs_inode").
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Looks correct,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/libxfs/xfs_inode_fork.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_inode_fork.c b/fs/xfs/libxfs/xfs_inode_fork.c
> index 7c34184448e6..fa699f3792bf 100644
> --- a/fs/xfs/libxfs/xfs_inode_fork.c
> +++ b/fs/xfs/libxfs/xfs_inode_fork.c
> @@ -724,8 +724,7 @@ xfs_ifork_verify_local_attr(
>
> if (fa) {
> xfs_inode_verifier_error(ip, -EFSCORRUPTED, "attr fork",
> - ifp ? ifp->if_u1.if_data : NULL,
> - ifp ? ifp->if_bytes : 0, fa);
> + ifp->if_u1.if_data, ifp->if_bytes, fa);
> return -EFSCORRUPTED;
> }
>
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-18 17:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-18 11:21 [PATCH] xfs: delete unnecessary NULL checks Dan Carpenter
2022-07-18 17:16 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox