From: "Darrick J. Wong" <djwong@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Dave Chinner <dchinner@redhat.com>,
Chandan Babu R <chandan.babu@oracle.com>,
Allison Henderson <allison.henderson@oracle.com>,
linux-xfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] xfs: delete unnecessary NULL checks
Date: Mon, 18 Jul 2022 10:16:40 -0700 [thread overview]
Message-ID: <YtWVeOjhL5R+CEJQ@magnolia> (raw)
In-Reply-To: <YtVCOtQ7PCRfjXY6@kili>
On Mon, Jul 18, 2022 at 02:21:30PM +0300, Dan Carpenter wrote:
> These NULL check are no long needed after commit 2ed5b09b3e8f ("xfs:
> make inode attribute forks a permanent part of struct xfs_inode").
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Looks correct,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/libxfs/xfs_inode_fork.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_inode_fork.c b/fs/xfs/libxfs/xfs_inode_fork.c
> index 7c34184448e6..fa699f3792bf 100644
> --- a/fs/xfs/libxfs/xfs_inode_fork.c
> +++ b/fs/xfs/libxfs/xfs_inode_fork.c
> @@ -724,8 +724,7 @@ xfs_ifork_verify_local_attr(
>
> if (fa) {
> xfs_inode_verifier_error(ip, -EFSCORRUPTED, "attr fork",
> - ifp ? ifp->if_u1.if_data : NULL,
> - ifp ? ifp->if_bytes : 0, fa);
> + ifp->if_u1.if_data, ifp->if_bytes, fa);
> return -EFSCORRUPTED;
> }
>
> --
> 2.35.1
>
prev parent reply other threads:[~2022-07-18 17:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 11:21 [PATCH] xfs: delete unnecessary NULL checks Dan Carpenter
2022-07-18 17:16 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtWVeOjhL5R+CEJQ@magnolia \
--to=djwong@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=chandan.babu@oracle.com \
--cc=dan.carpenter@oracle.com \
--cc=dchinner@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox