From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs_repair: retain superblock buffer to avoid write hook deadlock
Date: Thu, 11 Aug 2022 11:46:23 -0700 [thread overview]
Message-ID: <YvVOf3gl88K1RbYh@magnolia> (raw)
In-Reply-To: <YvT6XjTWPKfsPbI7@infradead.org>
On Thu, Aug 11, 2022 at 05:47:26AM -0700, Christoph Hellwig wrote:
> Maybe we just simply need to set NEEDSREPAIR for any run that does
> not specify the no-modify flag and avoid this magic lazy behavior?
Heh, which part of the magic lazy behavior? You asked for the bwrite
hook[1], and then Brian asked for a randomly triggered hook[2] in the
buffer cache IO path to enable testing, which now results in periodic
failures in xfs/155...
[1] https://lore.kernel.org/linux-xfs/20210209091336.GG1718132@infradead.org/
[2] https://lore.kernel.org/linux-xfs/20210212133503.GA321056@bfoster/
> That being said the code looks sane if we can't fix this better by
> just working differently.
There are too many patches in my tree for me to be able to take on more
refactoring.
--D
next prev parent reply other threads:[~2022-08-11 18:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 21:06 [PATCHSET v2 0/2] xfsprogs: random fixes for 5.19 Darrick J. Wong
2022-08-09 21:06 ` [PATCH 1/2] xfs_repair: fix printf format specifiers on 32-bit platforms Darrick J. Wong
2022-08-11 12:37 ` Christoph Hellwig
2022-08-09 21:06 ` [PATCH 2/2] xfs_repair: retain superblock buffer to avoid write hook deadlock Darrick J. Wong
2022-08-11 12:47 ` Christoph Hellwig
2022-08-11 18:46 ` Darrick J. Wong [this message]
2022-08-11 22:15 ` Dave Chinner
2022-08-16 2:12 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvVOf3gl88K1RbYh@magnolia \
--to=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox