From: "Darrick J. Wong" <djwong@kernel.org>
To: Zeng Heng <zengheng4@huawei.com>
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] xfs: remove "%Lu" which doesn't meet C standard
Date: Tue, 23 Aug 2022 07:27:11 -0700 [thread overview]
Message-ID: <YwTjv0bpf3Ed0JjS@magnolia> (raw)
In-Reply-To: <20220823015517.4160583-1-zengheng4@huawei.com>
On Tue, Aug 23, 2022 at 09:55:17AM +0800, Zeng Heng wrote:
> The "%Lu" specifier, which represents long long unsigned,
> doesn't meet C language standard, and even more,
> it makes people easily mistake with "%lu", which represent
> long unsigned. So replace "%Lu" with "llu".
>
> Signed-off-by: Zeng Heng <zengheng4@huawei.com>
Yesss finally fixing this
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_inode.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
> index 28493c8e9bb2..b3eeeae3afe1 100644
> --- a/fs/xfs/xfs_inode.c
> +++ b/fs/xfs/xfs_inode.c
> @@ -3119,7 +3119,7 @@ xfs_iflush(
> if (XFS_TEST_ERROR(dip->di_magic != cpu_to_be16(XFS_DINODE_MAGIC),
> mp, XFS_ERRTAG_IFLUSH_1)) {
> xfs_alert_tag(mp, XFS_PTAG_IFLUSH,
> - "%s: Bad inode %Lu magic number 0x%x, ptr "PTR_FMT,
> + "%s: Bad inode %llu magic number 0x%x, ptr "PTR_FMT,
> __func__, ip->i_ino, be16_to_cpu(dip->di_magic), dip);
> goto flush_out;
> }
> @@ -3129,7 +3129,7 @@ xfs_iflush(
> ip->i_df.if_format != XFS_DINODE_FMT_BTREE,
> mp, XFS_ERRTAG_IFLUSH_3)) {
> xfs_alert_tag(mp, XFS_PTAG_IFLUSH,
> - "%s: Bad regular inode %Lu, ptr "PTR_FMT,
> + "%s: Bad regular inode %llu, ptr "PTR_FMT,
> __func__, ip->i_ino, ip);
> goto flush_out;
> }
> @@ -3140,7 +3140,7 @@ xfs_iflush(
> ip->i_df.if_format != XFS_DINODE_FMT_LOCAL,
> mp, XFS_ERRTAG_IFLUSH_4)) {
> xfs_alert_tag(mp, XFS_PTAG_IFLUSH,
> - "%s: Bad directory inode %Lu, ptr "PTR_FMT,
> + "%s: Bad directory inode %llu, ptr "PTR_FMT,
> __func__, ip->i_ino, ip);
> goto flush_out;
> }
> @@ -3158,7 +3158,7 @@ xfs_iflush(
> if (XFS_TEST_ERROR(ip->i_forkoff > mp->m_sb.sb_inodesize,
> mp, XFS_ERRTAG_IFLUSH_6)) {
> xfs_alert_tag(mp, XFS_PTAG_IFLUSH,
> - "%s: bad inode %Lu, forkoff 0x%x, ptr "PTR_FMT,
> + "%s: bad inode %llu, forkoff 0x%x, ptr "PTR_FMT,
> __func__, ip->i_ino, ip->i_forkoff, ip);
> goto flush_out;
> }
> --
> 2.25.1
>
prev parent reply other threads:[~2022-08-23 16:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 1:55 [PATCH -next] xfs: remove "%Lu" which doesn't meet C standard Zeng Heng
2022-08-23 14:27 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwTjv0bpf3Ed0JjS@magnolia \
--to=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zengheng4@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox