From: "Darrick J. Wong" <djwong@kernel.org>
To: Zeng Heng <zengheng4@huawei.com>
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next 1/2] xfs: replace unnecessary seq_printf with seq_puts
Date: Mon, 29 Aug 2022 07:47:44 -0700 [thread overview]
Message-ID: <YwzRkC0lfp5zMaCQ@magnolia> (raw)
In-Reply-To: <20220829034217.732635-1-zengheng4@huawei.com>
On Mon, Aug 29, 2022 at 11:42:17AM +0800, Zeng Heng wrote:
> Replace seq_printf with seq_puts when const string
> in reference, which would avoid to deal with
> unnecessary string format.
>
> Signed-off-by: Zeng Heng <zengheng4@huawei.com>
Looks ok,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_stats.c b/fs/xfs/xfs_stats.c
> index 20e0534a772c..70d38b77682b 100644
> --- a/fs/xfs/xfs_stats.c
> +++ b/fs/xfs/xfs_stats.c
> @@ -125,7 +125,7 @@ static int xqmstat_proc_show(struct seq_file *m, void *v)
> {
> int j;
>
> - seq_printf(m, "qm");
> + seq_puts(m, "qm");
> for (j = XFSSTAT_START_XQMSTAT; j < XFSSTAT_END_XQMSTAT; j++)
> seq_printf(m, " %u", counter_val(xfsstats.xs_stats, j));
> seq_putc(m, '\n');
> --
> 2.25.1
>
prev parent reply other threads:[~2022-08-29 14:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 3:42 [PATCH -next 1/2] xfs: replace unnecessary seq_printf with seq_puts Zeng Heng
2022-08-29 14:47 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwzRkC0lfp5zMaCQ@magnolia \
--to=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zengheng4@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).