From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3587AC0502C for ; Mon, 29 Aug 2022 14:47:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229652AbiH2Ors (ORCPT ); Mon, 29 Aug 2022 10:47:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbiH2Orr (ORCPT ); Mon, 29 Aug 2022 10:47:47 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 488546B149; Mon, 29 Aug 2022 07:47:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E9A5EB81082; Mon, 29 Aug 2022 14:47:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A591CC433D6; Mon, 29 Aug 2022 14:47:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661784464; bh=rlvF1qPpe73oTYCMnsDsflOsWrgFu+HURhcGaeEcpgg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TmuUsXopHrX03B5zDadBEN89XJdrR1u09GGZeAnxzMT53a9eCd/Cs8+dfKkg7SX/w 0awPBqpL8h+sJAQ0koYFg38UB67KqDWhR7FpNcU7PZ9pVfJDIh7kqogNGnVd5ODtkp ODQMVdJIsauCARfF16PgFeEHKarYZqUN6tLeFjdEFULGD9Z7PGzoLAILacn7JitS+B nncPZ92NtbzJPjhjWOCPkJZwN8IJpGnSID9+Sk/Dy1ZBsSMAaeZvX6io6IfsMzLWh/ Iii554a17LnXk2ojHfK0U+U3m0SdkAPJPj7eijQuEjMmKpFF8Gfv+YJQE38Jc02r1G +c4aOHCfb5VYA== Date: Mon, 29 Aug 2022 07:47:44 -0700 From: "Darrick J. Wong" To: Zeng Heng Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next 1/2] xfs: replace unnecessary seq_printf with seq_puts Message-ID: References: <20220829034217.732635-1-zengheng4@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220829034217.732635-1-zengheng4@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Mon, Aug 29, 2022 at 11:42:17AM +0800, Zeng Heng wrote: > Replace seq_printf with seq_puts when const string > in reference, which would avoid to deal with > unnecessary string format. > > Signed-off-by: Zeng Heng Looks ok, Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/xfs_stats.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_stats.c b/fs/xfs/xfs_stats.c > index 20e0534a772c..70d38b77682b 100644 > --- a/fs/xfs/xfs_stats.c > +++ b/fs/xfs/xfs_stats.c > @@ -125,7 +125,7 @@ static int xqmstat_proc_show(struct seq_file *m, void *v) > { > int j; > > - seq_printf(m, "qm"); > + seq_puts(m, "qm"); > for (j = XFSSTAT_START_XQMSTAT; j < XFSSTAT_END_XQMSTAT; j++) > seq_printf(m, " %u", counter_val(xfsstats.xs_stats, j)); > seq_putc(m, '\n'); > -- > 2.25.1 >