From: "Darrick J. Wong" <djwong@kernel.org>
To: Zeng Heng <zengheng4@huawei.com>
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] xfs: missing space in xfs trace log
Date: Thu, 1 Sep 2022 09:09:55 -0700 [thread overview]
Message-ID: <YxDZUyN1XgawXvqD@magnolia> (raw)
In-Reply-To: <20220901110205.565167-1-zengheng4@huawei.com>
On Thu, Sep 01, 2022 at 07:02:05PM +0800, Zeng Heng wrote:
> Add space between arguments would help someone
> to locate the key words they want, so break
> quoted strings at a space character.
>
> Such as below:
> [Before]
> kworker/1:0-280 [001] ..... 600.782135: xfs_bunmap:
> dev 7:0 ino 0x85 disize 0x0 fileoff 0x0 fsbcount 0x400000001fffffflags ATTRFORK ...
>
> [After]
> kworker/1:2-564 [001] ..... 23817.906160: xfs_bunmap:
> dev 7:0 ino 0x85 disize 0x0 fileoff 0x0 fsbcount 0x400000001fffff flags ATTRFORK ...
>
> Signed-off-by: Zeng Heng <zengheng4@huawei.com>
Whoops, thanks for cleaning this up.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_trace.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
> index f9057af6e0c8..cb7c81ba7fa3 100644
> --- a/fs/xfs/xfs_trace.h
> +++ b/fs/xfs/xfs_trace.h
> @@ -1170,7 +1170,7 @@ DECLARE_EVENT_CLASS(xfs_dqtrx_class,
> __entry->ino_res_used = qtrx->qt_ino_res_used;
> __entry->icount_delta = qtrx->qt_icount_delta;
> ),
> - TP_printk("dev %d:%d dquot id 0x%x type %s flags %s"
> + TP_printk("dev %d:%d dquot id 0x%x type %s flags %s "
> "blk_res %llu bcount_delta %lld delbcnt_delta %lld "
> "rtblk_res %llu rtblk_res_used %llu rtbcount_delta %lld delrtb_delta %lld "
> "ino_res %llu ino_res_used %llu icount_delta %lld",
> @@ -1602,7 +1602,7 @@ TRACE_EVENT(xfs_bunmap,
> __entry->caller_ip = caller_ip;
> __entry->flags = flags;
> ),
> - TP_printk("dev %d:%d ino 0x%llx disize 0x%llx fileoff 0x%llx fsbcount 0x%llx"
> + TP_printk("dev %d:%d ino 0x%llx disize 0x%llx fileoff 0x%llx fsbcount 0x%llx "
> "flags %s caller %pS",
> MAJOR(__entry->dev), MINOR(__entry->dev),
> __entry->ino,
> --
> 2.25.1
>
prev parent reply other threads:[~2022-09-01 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 11:02 [PATCH -next] xfs: missing space in xfs trace log Zeng Heng
2022-09-01 16:09 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxDZUyN1XgawXvqD@magnolia \
--to=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zengheng4@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).