From: "Darrick J. Wong" <djwong@kernel.org>
To: Zeng Heng <zengheng4@huawei.com>
Cc: dchinner@redhat.com, chandan.babu@oracle.com,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
weiyongjun1@huawei.com, guoxuenan@huawei.com
Subject: Re: [PATCH -next] xfs: rmap: only XFS_DATA_FORK field would be set shared
Date: Wed, 7 Sep 2022 07:55:45 -0700 [thread overview]
Message-ID: <Yxiw8f55e0ZzjtNU@magnolia> (raw)
In-Reply-To: <20220906093554.899222-1-zengheng4@huawei.com>
On Tue, Sep 06, 2022 at 05:35:54PM +0800, Zeng Heng wrote:
> whichfork could be one of the following 3 types:
> XFS_DATA_FORK
> XFS_ATTR_FORK
> XFS_COW_FORK
>
> XFS_COW_FORK is in-memory field instead of on-disk
> field, which doesn't need to update in rmap_btree
> (already preclude by `xfs_rmap_update_is_needed` ahead).
>
> XFS_ATTR_FORK field doesn't support reflink share.
>
> So here propose to set "whichfork == XFS_DATA_FORK"
> as condition.
As you already state, xfs_rmap_update_is_needed() filters out
whichfork==XFS_COW_FORK. Why is this change necessary? It looks like
pointless churn to me.
--D
>
> Signed-off-by: Zeng Heng <zengheng4@huawei.com>
> ---
> fs/xfs/libxfs/xfs_rmap.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_rmap.c b/fs/xfs/libxfs/xfs_rmap.c
> index 094dfc897ebc..74b34a331cf0 100644
> --- a/fs/xfs/libxfs/xfs_rmap.c
> +++ b/fs/xfs/libxfs/xfs_rmap.c
> @@ -2549,7 +2549,7 @@ xfs_rmap_map_extent(
> if (!xfs_rmap_update_is_needed(tp->t_mountp, whichfork))
> return;
>
> - if (whichfork != XFS_ATTR_FORK && xfs_is_reflink_inode(ip))
> + if (whichfork == XFS_DATA_FORK && xfs_is_reflink_inode(ip))
> type = XFS_RMAP_MAP_SHARED;
>
> __xfs_rmap_add(tp, type, ip->i_ino, whichfork, PREV);
> @@ -2568,7 +2568,7 @@ xfs_rmap_unmap_extent(
> if (!xfs_rmap_update_is_needed(tp->t_mountp, whichfork))
> return;
>
> - if (whichfork != XFS_ATTR_FORK && xfs_is_reflink_inode(ip))
> + if (whichfork == XFS_DATA_FORK && xfs_is_reflink_inode(ip))
> type = XFS_RMAP_UNMAP_SHARED;
>
> __xfs_rmap_add(tp, type, ip->i_ino, whichfork, PREV);
> @@ -2593,7 +2593,7 @@ xfs_rmap_convert_extent(
> if (!xfs_rmap_update_is_needed(mp, whichfork))
> return;
>
> - if (whichfork != XFS_ATTR_FORK && xfs_is_reflink_inode(ip))
> + if (whichfork == XFS_DATA_FORK && xfs_is_reflink_inode(ip))
> type = XFS_RMAP_CONVERT_SHARED;
>
> __xfs_rmap_add(tp, type, ip->i_ino, whichfork, PREV);
> --
> 2.25.1
>
prev parent reply other threads:[~2022-09-07 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 9:35 [PATCH -next] xfs: rmap: only XFS_DATA_FORK field would be set shared Zeng Heng
2022-09-07 14:55 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yxiw8f55e0ZzjtNU@magnolia \
--to=djwong@kernel.org \
--cc=chandan.babu@oracle.com \
--cc=dchinner@redhat.com \
--cc=guoxuenan@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=zengheng4@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).