From: "Darrick J. Wong" <djwong@kernel.org>
To: Gaosheng Cui <cuigaosheng1@huawei.com>
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: remove xfs_setattr_time() declaration
Date: Wed, 14 Sep 2022 09:43:01 -0700 [thread overview]
Message-ID: <YyIElctvIHjAbmlK@magnolia> (raw)
In-Reply-To: <20220909065654.1156896-1-cuigaosheng1@huawei.com>
On Fri, Sep 09, 2022 at 02:56:54PM +0800, Gaosheng Cui wrote:
> xfs_setattr_time() has been removed since
> commit e014f37db1a2 ("xfs: use setattr_copy to set vfs inode
> attributes"), so remove it.
>
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
LGTM
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_iops.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_iops.h b/fs/xfs/xfs_iops.h
> index cb5fc68c9ea0..e570dcb5df8d 100644
> --- a/fs/xfs/xfs_iops.h
> +++ b/fs/xfs/xfs_iops.h
> @@ -13,7 +13,6 @@ extern const struct file_operations xfs_dir_file_operations;
>
> extern ssize_t xfs_vn_listxattr(struct dentry *, char *data, size_t size);
>
> -extern void xfs_setattr_time(struct xfs_inode *ip, struct iattr *iattr);
> int xfs_vn_setattr_size(struct user_namespace *mnt_userns,
> struct dentry *dentry, struct iattr *vap);
>
> --
> 2.25.1
>
prev parent reply other threads:[~2022-09-14 16:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5ULHhpqphBoOnMKjmfB_koRPr8gBCbu0c-YxXp0hWk_bW7qfDW1s_UDSEf9DgGb6e44nKcEmuQyZiD5rLWiKOQ==@protonmail.internalid>
2022-09-09 6:56 ` [PATCH] xfs: remove xfs_setattr_time() declaration Gaosheng Cui
2022-09-09 7:42 ` Carlos Maiolino
2022-09-14 16:43 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyIElctvIHjAbmlK@magnolia \
--to=djwong@kernel.org \
--cc=cuigaosheng1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox