From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: zlang@redhat.com, fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 03/17] logwrites: warn if we don't think read after discard returns zeroes
Date: Sun, 24 Nov 2024 21:12:26 -0800 [thread overview]
Message-ID: <Z0QHOjqagg5VuhFf@infradead.org> (raw)
In-Reply-To: <173229420060.358248.11054238752146807489.stgit@frogsfrogsfrogs>
This feels like it's heading in the wrong direction, as it just adds
more hacks.
IMHO the right thing is to:
a) document current assumptions and tell users very clearly to use
dm-thin to get the expected semantics
b) if we have a use for it, provide an option to use write zeroes
instead that can be used on any device
I'm happy to do that work, but until then I'd suggest to skip this and
the next two patches.
next prev parent reply other threads:[~2024-11-25 5:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 16:50 [PATCHSET v2] fstests: random fixes for v2024.11.17 Darrick J. Wong
2024-11-22 16:50 ` [PATCH 01/17] generic/757: fix various bugs in this test Darrick J. Wong
2024-11-22 16:50 ` [PATCH 02/17] generic/757: convert to thinp Darrick J. Wong
2024-11-25 5:10 ` Christoph Hellwig
2024-11-22 16:51 ` [PATCH 03/17] logwrites: warn if we don't think read after discard returns zeroes Darrick J. Wong
2024-11-25 5:12 ` Christoph Hellwig [this message]
2024-11-25 17:19 ` Darrick J. Wong
2024-11-22 16:51 ` [PATCH 04/17] logwrites: use BLKZEROOUT if it's available Darrick J. Wong
2024-11-22 16:51 ` [PATCH 05/17] logwrites: only use BLKDISCARD if we know discard zeroes data Darrick J. Wong
2024-11-22 16:52 ` [PATCH 06/17] xfs/113: fix failure to corrupt the entire directory Darrick J. Wong
2024-11-25 5:12 ` Christoph Hellwig
2024-11-22 16:52 ` [PATCH 07/17] xfs/508: fix test for 64k blocksize Darrick J. Wong
2024-11-25 5:13 ` Christoph Hellwig
2024-11-22 16:52 ` [PATCH 08/17] common/rc: capture dmesg when oom kills happen Darrick J. Wong
2024-11-25 5:13 ` Christoph Hellwig
2024-11-22 16:52 ` [PATCH 09/17] generic/562: handle ENOSPC while cloning gracefully Darrick J. Wong
2024-11-25 5:14 ` Christoph Hellwig
2024-11-25 5:16 ` Darrick J. Wong
2024-11-25 5:20 ` Christoph Hellwig
2024-11-26 1:26 ` Darrick J. Wong
2024-11-22 16:53 ` [PATCH 10/17] xfs/163: skip test if we can't shrink due to enospc issues Darrick J. Wong
2024-11-22 16:53 ` [PATCH 11/17] xfs/009: allow logically contiguous preallocations Darrick J. Wong
2024-11-22 16:53 ` [PATCH 12/17] generic/251: use sentinel files to kill the fstrim loop Darrick J. Wong
2024-11-22 16:53 ` [PATCH 13/17] generic/251: constrain runtime via time/load/soak factors Darrick J. Wong
2024-11-25 5:15 ` Christoph Hellwig
2024-11-22 16:54 ` [PATCH 14/17] generic/251: don't copy the fsstress source code Darrick J. Wong
2024-11-25 5:15 ` Christoph Hellwig
2024-11-22 16:54 ` [PATCH 15/17] common/rc: _scratch_mkfs_sized supports extra arguments Darrick J. Wong
2024-11-22 16:54 ` [PATCH 16/17] xfs/157: do not drop necessary mkfs options Darrick J. Wong
2024-11-22 16:54 ` [PATCH 17/17] generic/366: fix directio requirements checking Darrick J. Wong
2024-11-25 5:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0QHOjqagg5VuhFf@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox