public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Stephen Zhang <starzhangzsd@gmail.com>
Cc: djwong@kernel.org, dchinner@redhat.com, leo.lilong@huawei.com,
	wozizhi@huawei.com, osandov@fb.com, xiang@kernel.org,
	zhangjiachen.jaycee@bytedance.com, linux-xfs@vger.kernel.org,
	linux-kernel@vger.kernel.org, zhangshida@kylinos.cn
Subject: Re: [PATCH 0/5] *** Introduce new space allocation algorithm ***
Date: Tue, 26 Nov 2024 11:51:29 +1100	[thread overview]
Message-ID: <Z0UbkWlaEuH9_bXd@dread.disaster.area> (raw)
In-Reply-To: <CANubcdX2q+HqZTw8v1Eqi560X841fzOFX=BzgVdEi=KwP7eijw@mail.gmail.com>

On Thu, Nov 21, 2024 at 03:17:04PM +0800, Stephen Zhang wrote:
> Dave Chinner <david@fromorbit.com> 于2024年11月21日周四 06:53写道:
> >
> > On Sun, Nov 17, 2024 at 09:34:53AM +0800, Stephen Zhang wrote:
> > > Dave Chinner <david@fromorbit.com> 于2024年11月11日周一 10:04写道:
> > > >
> > > > On Fri, Nov 08, 2024 at 09:34:17AM +0800, Stephen Zhang wrote:
> > > > > Dave Chinner <david@fromorbit.com> 于2024年11月4日周一 20:15写道:
> > > > > > On Mon, Nov 04, 2024 at 05:25:38PM +0800, Stephen Zhang wrote:
> > > > > > > Dave Chinner <david@fromorbit.com> 于2024年11月4日周一 11:32写道:
> > > > > > > > On Mon, Nov 04, 2024 at 09:44:34AM +0800, zhangshida wrote:
> > > Hi, I have tested the inode32 mount option. To my suprise, the inode32
> > > or the metadata preferred structure (will be referred to as inode32 for the
> > > rest reply) doesn't implement the desired behavior as the AF rule[1] does:
> > >         Lower AFs/AGs will do anything they can for allocation before going
> > > to HIGHER/RESERVED AFs/AGS. [1]
> >
> > This isn't important or relevant to the experiment I asked you to
> > perform and report the results of.
> >
> > I asked you to observe and report the filesystem fill pattern in
> > your environment when metadata preferred AGs are enabled. It isn't
> > important whether inode32 exactly solves your problem, what I want
> > to know is whether the underlying mechanism has sufficient control
> > to provide a general solution that is always enabled.
> >
> > This is foundational engineering process: check your hypothesis work
> > as you expect before building more stuff on top of them. i.e.
> > perform experiments to confirm your ideas will work before doing
> > anything else.
> >
> > If you answer a request for an experiment to be run with "theory
> > tells me it won't work" then you haven't understood why you were
> > asked to run an experiment in the first place.
> >
> 
> If I understand your reply correctly, then maybe my expression is the

You didn't understand my reply correctly.

I asked you to stop repeating the same explanation of your algorithm
in response to every question I asked you.

I asked you to stop trying to explain why something you just
learnt about from a subject matter expert wouldn't fix your problem.

I asked you to perform an experiment to confirm behaviour was as
expected under your problematic workload.

Your reply:

> problem. What I replied before is:
> 1. I have tested the inode32 option with the metadata preferred AGs
> enabled(Yeah, I do check if the AG is set with
> XFS_AGSTATE_PREFERS_METADATA). And with the alternating-
> punching pattern, I observed that the preferred AG will still get fragmented
> quickly, but the AF will not.
> (That's what I meant in the first sentence of my previous reply...)

is simply restating what you said in the previous email that I
explicitly told you didn't answer the question I was asking you.

Please listen to what I'm asking you to do. You don't need to
explain anything to me, I just want you to run an experiment and
report the results.

This isn't a hard thing to do: the inode32 filesystem should fill to
roughly 50% before it really starts to spill to the lower AGs.
Record and paste the 'xfs_spaceman -c "freesp -a X"' histograms for
each AG when the filesystem is a little over half full.

That's it. I don't need you to explain anything to me, I simply want
to know if the inode32 allocation policy does, in fact, work the way
it is expected to under your problematic workload.

-Dave.
-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2024-11-26  0:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-04  1:44 [PATCH 0/5] *** Introduce new space allocation algorithm *** zhangshida
2024-11-04  1:44 ` [PATCH 1/5] xfs: add two wrappers for iterating ags in a AF zhangshida
2024-11-04  1:44 ` [PATCH 2/5] xfs: add two mp member to record the alloction field layout zhangshida
2024-11-04  1:44 ` [PATCH 3/5] xfs: add mount options as a way to change the AF layout zhangshida
2024-11-04  1:44 ` [PATCH 4/5] xfs: add infrastructure to support AF allocation algorithm zhangshida
2024-11-04  1:44 ` [PATCH 5/5] xfs: modify the logic to comply with AF rules zhangshida
2024-11-04  1:49 ` [PATCH 0/5] *** Introduce new space allocation algorithm *** Stephen Zhang
2024-11-04  3:34   ` Dave Chinner
2024-11-04  6:55     ` Stephen Zhang
2024-11-04  3:32 ` Dave Chinner
2024-11-04  9:25   ` Stephen Zhang
2024-11-04 12:15     ` Dave Chinner
2024-11-08  1:34       ` Stephen Zhang
2024-11-11  2:04         ` Dave Chinner
2024-11-17  1:34           ` Stephen Zhang
2024-11-20 22:53             ` Dave Chinner
2024-11-21  7:17               ` Stephen Zhang
2024-11-26  0:51                 ` Dave Chinner [this message]
2024-12-18  1:31                   ` Stephen Zhang
  -- strict thread matches above, loose matches on Subject: below --
2024-11-04  1:40 zhangshida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z0UbkWlaEuH9_bXd@dread.disaster.area \
    --to=david@fromorbit.com \
    --cc=dchinner@redhat.com \
    --cc=djwong@kernel.org \
    --cc=leo.lilong@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=osandov@fb.com \
    --cc=starzhangzsd@gmail.com \
    --cc=wozizhi@huawei.com \
    --cc=xiang@kernel.org \
    --cc=zhangjiachen.jaycee@bytedance.com \
    --cc=zhangshida@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox