From: Long Li <leo.lilong@huawei.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: <brauner@kernel.org>, <djwong@kernel.org>, <cem@kernel.org>,
<linux-xfs@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
<yi.zhang@huawei.com>, <houtao1@huawei.com>,
<yangerkun@huawei.com>
Subject: Re: [PATCH v4 1/2] iomap: fix zero padding data issue in concurrent append writes
Date: Tue, 26 Nov 2024 14:53:45 +0800 [thread overview]
Message-ID: <Z0Vwed_tGNAC-adv@localhost.localdomain> (raw)
In-Reply-To: <Z0VqmgQisdDxlSAy@infradead.org>
On Mon, Nov 25, 2024 at 10:28:42PM -0800, Christoph Hellwig wrote:
> On Mon, Nov 25, 2024 at 09:42:48PM +0800, Long Li wrote:
> > I agree with Brian's point. The scenarios where rounding up io_size
> > enables ioend merging are quite rare, so the practical benefits are
> > limited, though such cases can still exist. Therefore, I think both
> > approaches are acceptable as there doesn't seem to be a significant
> > difference between them.
>
> Given that not rounding and using the unaligned value should be
> a lot simpler, can you give it a try?
>
Okay, so let me send a new version and change it.
Thanks,
Long Li
prev parent reply other threads:[~2024-11-26 6:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 2:33 [PATCH v4 1/2] iomap: fix zero padding data issue in concurrent append writes Long Li
2024-11-25 2:33 ` [PATCH v4 2/2] xfs: clean up xfs_end_ioend() to reuse local variables Long Li
2024-11-25 6:40 ` [PATCH v4 1/2] iomap: fix zero padding data issue in concurrent append writes Christoph Hellwig
2024-11-25 13:42 ` Long Li
2024-11-26 6:28 ` Christoph Hellwig
2024-11-26 6:53 ` Long Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0Vwed_tGNAC-adv@localhost.localdomain \
--to=leo.lilong@huawei.com \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=houtao1@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox