Re: [PATCH 29/50] xfs_db: support changing the label and uuid of rt superblocks

Christoph Hellwig
2024-12-10T05:42:08Z

On Fri, Dec 06, 2024 at 04:12:31PM -0800, Darrick J. Wong wrote:
>u + struct xfs_mount *mp)
> +{
> + int error;
> +
> + if (!xfs_has_rtsb(mp) || !xfs_has_realtime(mp))

Nit: I would have expected the checks to be reversed just from a reading
flow perspective:

if (!xfs_has_realtime(mp) || !xfs_has_rtsb(mp))

But in the end it does not matter.

Reviewed-by: Christoph Hellwig <hch@lst.de>