Re: [PATCH 24/41] xfs_repair: refactor marking of metadata inodes

Christoph Hellwig
2024-12-10T05:07:04Z

> +mark_inode(
> + struct xfs_mount *mp,
> + xfs_ino_t ino)
> +{
> + struct ino_tree_node *irec;
> + int offset;
> +
> + irec = find_inode_rec(mp, XFS_INO_TO_AGNO(mp, ino),
> + XFS_INO_TO_AGINO(mp, ino));
> +
> + offset = XFS_INO_TO_AGINO(mp, ino) - irec->ino_startnum;
> +
> + add_inode_reached(irec, offset);

Nit: I'd just skip the local offset variable.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>