Re: [PATCHSET 6/9] xfsprogs: bug fixes for 6.13

Darrick J. Wong
2024-12-11T19:40:23Z

On Mon, Dec 09, 2024 at 09:25:02PM -0800, Christoph Hellwig wrote:
> Shouldn't the bug fix series go first?

Something got messed up in the patchbombing sequence. Patchset 5/9
should have sorted before this one (6/9) but instead it came at the end.

Ohhh, right. Long Li add a "Cc: stable@vger.kernel.org # v4.19+"
tag. This isn't rfc2822 compliant, so the stgit subcommand that
converts Cc: tags in the commit message to actual cc: headers tried to
put the entire string (minus spaces!) in the cc line, which caused the
msmtp to reject the cover letter. I stripped out the stable@ entirely
and resent just that message, but forgot that my patchbombing script
always updates the send time for each attempt, so the mutt sort order is
now incorrect.

String parsing sucks, and our automated tools don't catch it either:

$ ./scripts/checkpatch.pl ../xfsprogs/patches-djwong-dev10/129*
ERROR: Please use git commit description style 'commit <12+ chars of sha1> (" ")'
- ie: 'commit 652f03db897b ("xfs: remove unknown compat feature check in superblock write validation")'
#4:
Source kernel commit: 652f03db897ba24f9c4b269e254ccc6cc01ff1b7

total: 1 errors, 0 warnings, 13 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

../xfsprogs/patches-djwong-dev10/129-xfs__remove_unknown_compat_feature_check_in_superblock_write_validation.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Yeah, it whines about the commit hash being **too long** which is
totally inconsequential but totally misses the incorrect Cc: header
specification that confuses the hyell out of MTAs.

Sorry about that.

--D