From: Jon DeVree <nuxi@vault24.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: grub-devel@gnu.org,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
Anthony Iliopoulos <ailiop@suse.com>,
Marta Lewandowska <mlewando@redhat.com>,
Andrey Albershteyn <aalbersh@redhat.com>
Subject: Re: [PATCH GRUB] fs/xfs: fix large extent counters incompat feature support
Date: Thu, 12 Dec 2024 21:22:29 -0500 [thread overview]
Message-ID: <Z1uaZbUUptETLjWH@feynman.vault24.org> (raw)
In-Reply-To: <985816b8-35e6-4083-994f-ec9138bd35d2@redhat.com>
On Wed, Dec 04, 2024 at 07:50:28 -0600, Eric Sandeen wrote:
> When large extent counter / NREXT64 support was added to grub, it missed
> a couple of direct reads of nextents which need to be changed to the new
> NREXT64-aware helper as well. Without this, we'll have mis-reads of some
> directories with this feature enabled.
>
> (The large extent counter fix likely raced on merge with
> 07318ee7e ("fs/xfs: Fix XFS directory extent parsing") which added the new
> direct nextents reads just prior, causing this issue.)
>
> Fixes: aa7c1322671e ("fs/xfs: Add large extent counters incompat feature support")
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Good catch.
Reviewed-by: Jon DeVree <nuxi@vault24.org>
--
Jon
Doge Wrangler
X(7): A program for managing terminal windows. See also screen(1) and tmux(1).
next prev parent reply other threads:[~2024-12-13 2:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 13:50 [PATCH GRUB] fs/xfs: fix large extent counters incompat feature support Eric Sandeen
2024-12-04 20:13 ` Anthony Iliopoulos
2024-12-13 2:22 ` Jon DeVree [this message]
2025-03-27 19:48 ` Eric Sandeen
2025-04-16 1:08 ` Eric Sandeen
2025-04-17 18:34 ` Daniel Kiper
2025-04-17 18:51 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1uaZbUUptETLjWH@feynman.vault24.org \
--to=nuxi@vault24.org \
--cc=aalbersh@redhat.com \
--cc=ailiop@suse.com \
--cc=grub-devel@gnu.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mlewando@redhat.com \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox