Re: [PATCH 43/43] xfs: enable realtime reflink

Darrick J. Wong
2024-12-17T20:57:00Z

On Fri, Dec 13, 2024 at 01:25:50AM -0800, Christoph Hellwig wrote:
> > - if (xfs_globals.always_cow) {
> > + /*
> > + * always-cow mode is not supported on filesystems with rt
> > + * extent sizes larger than a single block because we'd have
> > + * to perform write-around for unaligned writes because remap
> > + * requests must be aligned to an rt extent.
> > + */
> > + if (xfs_globals.always_cow &&
> > + (!xfs_has_realtime(mp) || mp->m_sb.sb_rextsize == 1)) {
>
> This looks unrelated to the rest of the patch, or am I missing
> something?

Yeah, this belongs in the next series.

--D