Re: [PATCH 03/43] xfs: introduce realtime refcount btree ondisk definitions

Darrick J. Wong
2024-12-17T20:44:54Z

On Fri, Dec 13, 2024 at 01:08:28AM -0800, Christoph Hellwig wrote:
> > xfs_rtbtree_compute_maxlevels(
> > struct xfs_mount *mp)
> > {
> > - mp->m_rtbtree_maxlevels = mp->m_rtrmap_maxlevels;
> > + unsigned int levels;
> > +
> > + levels = max(mp->m_rtrmap_maxlevels, mp->m_rtrefc_maxlevels);
> > + mp->m_rtbtree_maxlevels = levels;
> > }
>
> I'd drop the extra local variable here.

Done.

> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks!

--D