Re: [PATCH 11/37] xfs: support file data forks containing metadata btrees

Christoph Hellwig
2024-12-13T06:49:04Z

> if (unlikely(S_ISREG(ldip->di_mode))) {
> if ((ldip->di_format != XFS_DINODE_FMT_EXTENTS) &&
> - (ldip->di_format != XFS_DINODE_FMT_BTREE)) {
> + (ldip->di_format != XFS_DINODE_FMT_BTREE) &&
> + (ldip->di_format != XFS_DINODE_FMT_META_BTREE)) {

Maybe drop the pointless inner braces here instead of adding more?

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>