Re: [PATCHSET v6.0 5/5] xfs: reflink with large realtime extents

Christoph Hellwig
2024-12-13T08:30:56Z

On Thu, Dec 12, 2024 at 04:57:58PM -0800, Darrick J. Wong wrote:
> Hi all,
>
> Now that we've landed support for reflink on the realtime device for
> cases where the rt extent size is the same as the fs block size, enhance
> the reflink code further to support cases where the rt extent size is a
> power-of-two multiple of the fs block size. This enables us to do data
> block sharing (for example) for much larger allocation units by dirtying
> pagecache around shared extents and expanding writeback to write back
> shared extents fully.

FYI, I'd really like to avoid us pushing the large allocation sizes
further than we have to. Or in other words, unless we have a really
important use case for this I'd prefer not to merge this code.