Re: [PATCH 32/37] xfs: online repair of the realtime rmap btree

Christoph Hellwig
2024-12-18T06:55:01Z

On Tue, Dec 17, 2024 at 12:41:12PM -0800, Darrick J. Wong wrote:
> On Thu, Dec 12, 2024 at 11:29:16PM -0800, Christoph Hellwig wrote:
> > > Repair the realtime rmap btree while mounted.
> >
> > And actual description of how this repair works, and the changes to the
> > non-repair code required for it would be kinda useful.
>
> How about:
>
> "Repair the realtime rmap btree while mounted. Similar to the regular
> rmap btree repair code, we walk the data fork mappings of every realtime
> file in the filesystem to collect reverse-mapping records in an xfarray.
> Then we sort the xfarray, and use the btree bulk loader to create a new
> rtrmap btree ondisk. Finally, we swap the btree roots, and reap the old
> blocks in the usual way."

Sounds good.