Re: [PATCH 6/8] xfs: hoist the node iroot update code out of xfs_btree_new_iroot

Christoph Hellwig
2024-12-13T06:09:06Z

On Thu, Dec 12, 2024 at 04:59:32PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> In preparation for allowing records in an inode btree root, hoist the
> code that copies keyptrs from an existing node root into a child block
> to a separate function. Note that the new function explicitly computes
> the keys of the new child block and stores that in the root block; while
> the bmap btree could rely on leaving the key alone, realtime rmap needs
> to set the new high key.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>