From: Brian Foster <bfoster@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
cem@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 02/21] xfs: create incore realtime group structures
Date: Mon, 16 Dec 2024 08:25:57 -0500 [thread overview]
Message-ID: <Z2AqZaGP587xtjWq@bfoster> (raw)
In-Reply-To: <Z1_K_Bo9lmhJez8R@infradead.org>
On Sun, Dec 15, 2024 at 10:38:52PM -0800, Christoph Hellwig wrote:
> On Tue, Dec 10, 2024 at 07:51:32PM -0800, Christoph Hellwig wrote:
> > So without CONFIG_XFS_RT we obviously should not update rgcounts,
> > but should also fail the mount earlier if there are RGs. Turns out
> > that non-rtg file systems have a fake RTG if they have a rt subvolume,
> > and the count is always set to 1. So yes, this should just return 0
> > and your fix is correct.
>
> Are you going to send this fix formally? Or should I?
>
>
I don't really have a patch to send. I was just trying to provide enough
debug analysis to hopefully be useful to somebody who knows this code
better than I do..
Brian
next prev parent reply other threads:[~2024-12-16 13:24 UTC|newest]
Thread overview: 156+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 21:58 [PATCHBOMB 6.13 v5.5] xfs: metadata directories and realtime groups Darrick J. Wong
2024-11-05 22:04 ` [PATCHSET v5.5 01/10] xfs: convert perag to use xarrays Darrick J. Wong
2024-11-05 22:06 ` [PATCH 01/23] xfs: fix simplify extent lookup in xfs_can_free_eofblocks Darrick J. Wong
2024-11-05 22:07 ` [PATCH 02/23] xfs: fix superfluous clearing of info->low in __xfs_getfsmap_datadev Darrick J. Wong
2024-11-05 22:07 ` [PATCH 03/23] xfs: remove the unused pagb_count field in struct xfs_perag Darrick J. Wong
2024-11-05 22:07 ` [PATCH 04/23] xfs: remove the unused pag_active_wq " Darrick J. Wong
2024-11-05 22:07 ` [PATCH 05/23] xfs: pass a pag to xfs_difree_inode_chunk Darrick J. Wong
2024-11-05 22:08 ` [PATCH 06/23] xfs: remove the agno argument to xfs_free_ag_extent Darrick J. Wong
2024-11-05 22:08 ` [PATCH 07/23] xfs: add xfs_agbno_to_fsb and xfs_agbno_to_daddr helpers Darrick J. Wong
2024-11-05 22:08 ` [PATCH 08/23] xfs: add a xfs_agino_to_ino helper Darrick J. Wong
2024-11-05 22:08 ` [PATCH 09/23] xfs: pass a pag to xfs_extent_busy_{search,reuse} Darrick J. Wong
2024-11-05 22:09 ` [PATCH 10/23] xfs: keep a reference to the pag for busy extents Darrick J. Wong
2024-11-05 22:09 ` [PATCH 11/23] xfs: remove the mount field from struct xfs_busy_extents Darrick J. Wong
2024-11-05 22:09 ` [PATCH 12/23] xfs: remove the unused trace_xfs_iwalk_ag trace point Darrick J. Wong
2024-11-05 22:09 ` [PATCH 13/23] xfs: remove the unused xrep_bmap_walk_rmap " Darrick J. Wong
2024-11-05 22:10 ` [PATCH 14/23] xfs: constify pag arguments to trace points Darrick J. Wong
2024-11-05 22:10 ` [PATCH 15/23] xfs: pass a perag structure to the xfs_ag_resv_init_error trace point Darrick J. Wong
2024-11-05 22:10 ` [PATCH 16/23] xfs: pass objects to the xfs_irec_merge_{pre,post} trace points Darrick J. Wong
2024-11-05 22:10 ` [PATCH 17/23] xfs: pass the iunlink item to the xfs_iunlink_update_dinode trace point Darrick J. Wong
2024-11-05 22:11 ` [PATCH 18/23] xfs: pass objects to the xrep_ibt_walk_rmap tracepoint Darrick J. Wong
2024-11-05 22:11 ` [PATCH 19/23] xfs: pass the pag to the trace_xrep_calc_ag_resblks{,_btsize} trace points Darrick J. Wong
2024-11-05 22:11 ` [PATCH 20/23] xfs: pass the pag to the xrep_newbt_extent_class tracepoints Darrick J. Wong
2024-11-05 22:11 ` [PATCH 21/23] xfs: convert remaining trace points to pass pag structures Darrick J. Wong
2024-11-05 22:12 ` [PATCH 22/23] xfs: split xfs_initialize_perag Darrick J. Wong
2024-11-05 22:12 ` [PATCH 23/23] xfs: insert the pag structures into the xarray later Darrick J. Wong
2024-11-05 22:04 ` [PATCHSET v5.5 02/10] xfs: create a generic allocation group structure Darrick J. Wong
2024-11-05 22:12 ` [PATCH 01/16] xfs: factor out a xfs_iwalk_args helper Darrick J. Wong
2024-11-05 22:12 ` [PATCH 02/16] xfs: factor out a generic xfs_group structure Darrick J. Wong
2024-11-05 22:13 ` [PATCH 03/16] xfs: add a xfs_group_next_range helper Darrick J. Wong
2024-11-05 22:13 ` [PATCH 04/16] xfs: switch perag iteration from the for_each macros to a while based iterator Darrick J. Wong
2024-11-05 22:13 ` [PATCH 05/16] xfs: move metadata health tracking to the generic group structure Darrick J. Wong
2024-11-05 22:14 ` [PATCH 06/16] xfs: mark xfs_perag_intent_{hold,rele} static Darrick J. Wong
2024-11-05 22:14 ` [PATCH 07/16] xfs: move draining of deferred operations to the generic group structure Darrick J. Wong
2024-11-05 22:14 ` [PATCH 08/16] xfs: move the online repair rmap hooks " Darrick J. Wong
2024-11-05 22:14 ` [PATCH 09/16] xfs: return the busy generation from xfs_extent_busy_list_empty Darrick J. Wong
2024-11-05 22:15 ` [PATCH 10/16] xfs: convert extent busy tracepoints to the generic group structure Darrick J. Wong
2024-11-05 22:15 ` [PATCH 11/16] xfs: convert busy extent tracking " Darrick J. Wong
2024-11-05 22:15 ` [PATCH 12/16] xfs: add a generic group pointer to the btree cursor Darrick J. Wong
2024-11-05 22:15 ` [PATCH 13/16] xfs: store a generic xfs_group pointer in xfs_getfsmap_info Darrick J. Wong
2024-11-05 22:16 ` [PATCH 14/16] xfs: add group based bno conversion helpers Darrick J. Wong
2024-11-05 22:16 ` [PATCH 15/16] xfs: remove xfs_group_intent_hold and xfs_group_intent_rele Darrick J. Wong
2024-11-05 22:16 ` [PATCH 16/16] xfs: store a generic group structure in the intents Darrick J. Wong
2024-11-05 22:04 ` [PATCHSET v5.5 03/10] xfs: metadata inode directory trees Darrick J. Wong
2024-11-05 22:16 ` [PATCH 01/28] xfs: constify the xfs_sb predicates Darrick J. Wong
2024-11-05 22:17 ` [PATCH 02/28] xfs: constify the xfs_inode predicates Darrick J. Wong
2024-11-05 22:17 ` [PATCH 03/28] xfs: rename metadata inode predicates Darrick J. Wong
2024-11-05 22:17 ` [PATCH 04/28] xfs: standardize EXPERIMENTAL warning generation Darrick J. Wong
2024-11-05 22:17 ` [PATCH 05/28] xfs: define the on-disk format for the metadir feature Darrick J. Wong
2024-11-05 22:18 ` [PATCH 06/28] xfs: iget for metadata inodes Darrick J. Wong
2024-11-05 22:18 ` [PATCH 07/28] xfs: load metadata directory root at mount time Darrick J. Wong
2024-11-05 22:18 ` [PATCH 08/28] xfs: enforce metadata inode flag Darrick J. Wong
2024-11-05 22:18 ` [PATCH 09/28] xfs: read and write metadata inode directory tree Darrick J. Wong
2024-11-05 22:19 ` [PATCH 10/28] xfs: disable the agi rotor for metadata inodes Darrick J. Wong
2024-11-05 22:19 ` [PATCH 11/28] xfs: hide metadata inodes from everyone because they are special Darrick J. Wong
2024-11-05 22:19 ` [PATCH 12/28] xfs: advertise metadata directory feature Darrick J. Wong
2024-11-05 22:20 ` [PATCH 13/28] xfs: allow bulkstat to return metadata directories Darrick J. Wong
2024-11-05 22:20 ` [PATCH 14/28] xfs: don't count metadata directory files to quota Darrick J. Wong
2024-11-05 22:20 ` [PATCH 15/28] xfs: mark quota inodes as metadata files Darrick J. Wong
2024-11-05 22:20 ` [PATCH 16/28] xfs: adjust xfs_bmap_add_attrfork for metadir Darrick J. Wong
2024-11-05 22:21 ` [PATCH 17/28] xfs: record health problems with the metadata directory Darrick J. Wong
2024-11-05 22:21 ` [PATCH 18/28] xfs: refactor directory tree root predicates Darrick J. Wong
2024-11-05 22:21 ` [PATCH 19/28] xfs: do not count metadata directory files when doing online quotacheck Darrick J. Wong
2024-11-05 22:21 ` [PATCH 20/28] xfs: metadata files can have xattrs if metadir is enabled Darrick J. Wong
2024-11-05 22:22 ` [PATCH 21/28] xfs: adjust parent pointer scrubber for sb-rooted metadata files Darrick J. Wong
2024-11-05 22:22 ` [PATCH 22/28] xfs: fix di_metatype field of inodes that won't load Darrick J. Wong
2024-11-05 22:22 ` [PATCH 23/28] xfs: scrub metadata directories Darrick J. Wong
2024-11-05 22:22 ` [PATCH 24/28] xfs: check the metadata directory inumber in superblocks Darrick J. Wong
2024-11-05 22:23 ` [PATCH 25/28] xfs: move repair temporary files to the metadata directory tree Darrick J. Wong
2024-11-05 22:23 ` [PATCH 26/28] xfs: check metadata directory file path connectivity Darrick J. Wong
2024-11-05 22:23 ` [PATCH 27/28] xfs: confirm dotdot target before replacing it during a repair Darrick J. Wong
2024-11-05 22:23 ` [PATCH 28/28] xfs: repair metadata directory file path connectivity Darrick J. Wong
2024-11-05 22:04 ` [PATCHSET v5.5 04/10] xfs: create incore rt allocation groups Darrick J. Wong
2024-11-05 22:24 ` [PATCH 01/21] xfs: clean up xfs_getfsmap_helper arguments Darrick J. Wong
2024-11-05 22:24 ` [PATCH 02/21] xfs: create incore realtime group structures Darrick J. Wong
2024-12-10 12:29 ` Brian Foster
2024-12-11 3:51 ` Christoph Hellwig
2024-12-16 6:38 ` Christoph Hellwig
2024-12-16 13:25 ` Brian Foster [this message]
2024-11-05 22:24 ` [PATCH 03/21] xfs: define locking primitives for realtime groups Darrick J. Wong
2024-11-05 22:24 ` [PATCH 04/21] xfs: add a lockdep class key for rtgroup inodes Darrick J. Wong
2024-11-05 22:25 ` [PATCH 05/21] xfs: support caching rtgroup metadata inodes Darrick J. Wong
2024-11-05 22:25 ` [PATCH 06/21] xfs: add rtgroup-based realtime scrubbing context management Darrick J. Wong
2024-11-05 22:25 ` [PATCH 07/21] xfs: add a xfs_bmap_free_rtblocks helper Darrick J. Wong
2024-11-05 22:26 ` [PATCH 08/21] xfs: add a xfs_qm_unmount_rt helper Darrick J. Wong
2024-11-05 22:26 ` [PATCH 09/21] xfs: factor out a xfs_growfs_rt_alloc_blocks helper Darrick J. Wong
2024-11-05 22:26 ` [PATCH 10/21] xfs: cleanup xfs_getfsmap_rtdev_rtbitmap Darrick J. Wong
2024-11-05 22:26 ` [PATCH 11/21] xfs: split xfs_trim_rtdev_extents Darrick J. Wong
2024-11-05 22:27 ` [PATCH 12/21] xfs: move RT bitmap and summary information to the rtgroup Darrick J. Wong
2024-11-05 22:27 ` [PATCH 13/21] xfs: support creating per-RTG files in growfs Darrick J. Wong
2024-11-05 22:27 ` [PATCH 14/21] xfs: remove XFS_ILOCK_RT* Darrick J. Wong
2024-11-05 22:27 ` [PATCH 15/21] xfs: calculate RT bitmap and summary blocks based on sb_rextents Darrick J. Wong
2024-11-05 22:28 ` [PATCH 16/21] xfs: factor out a xfs_growfs_rt_alloc_fake_mount helper Darrick J. Wong
2024-11-05 22:28 ` [PATCH 17/21] xfs: use xfs_growfs_rt_alloc_fake_mount in xfs_growfs_rt_alloc_blocks Darrick J. Wong
2024-11-05 22:28 ` [PATCH 18/21] xfs: factor out a xfs_growfs_check_rtgeom helper Darrick J. Wong
2024-11-05 22:28 ` [PATCH 19/21] xfs: refactor xfs_rtbitmap_blockcount Darrick J. Wong
2024-11-05 22:29 ` [PATCH 20/21] xfs: refactor xfs_rtsummary_blockcount Darrick J. Wong
2024-11-05 22:29 ` [PATCH 21/21] xfs: make RT extent numbers relative to the rtgroup Darrick J. Wong
2024-11-05 22:05 ` [PATCHSET v5.5 05/10] xfs: preparation for realtime allocation groups Darrick J. Wong
2024-11-05 22:29 ` [PATCH 1/2] xfs: fix rt device offset calculations for FITRIM Darrick J. Wong
2024-11-05 22:29 ` [PATCH 2/2] iomap: add a merge boundary flag Darrick J. Wong
2024-11-05 22:05 ` [PATCHSET v5.5 06/10] xfs: shard the realtime section Darrick J. Wong
2024-11-05 22:30 ` [PATCH 01/34] xfs: define the format of rt groups Darrick J. Wong
2024-11-05 22:30 ` [PATCH 02/34] xfs: check the realtime superblock at mount time Darrick J. Wong
2024-11-05 22:30 ` [PATCH 03/34] xfs: update realtime super every time we update the primary fs super Darrick J. Wong
2024-11-05 22:30 ` [PATCH 04/34] xfs: export realtime group geometry via XFS_FSOP_GEOM Darrick J. Wong
2024-11-05 22:31 ` [PATCH 05/34] xfs: check that rtblock extents do not break rtsupers or rtgroups Darrick J. Wong
2024-11-05 22:31 ` [PATCH 06/34] xfs: add a helper to prevent bmap merges across rtgroup boundaries Darrick J. Wong
2024-11-05 22:31 ` [PATCH 07/34] xfs: add frextents to the lazysbcounters when rtgroups enabled Darrick J. Wong
2024-11-05 22:31 ` [PATCH 08/34] xfs: convert sick_map loops to use ARRAY_SIZE Darrick J. Wong
2024-11-05 22:32 ` [PATCH 09/34] xfs: record rt group metadata errors in the health system Darrick J. Wong
2024-11-05 22:32 ` [PATCH 10/34] xfs: export the geometry of realtime groups to userspace Darrick J. Wong
2024-11-05 22:32 ` [PATCH 11/34] xfs: add block headers to realtime bitmap and summary blocks Darrick J. Wong
2024-11-05 22:33 ` [PATCH 12/34] xfs: encode the rtbitmap in big endian format Darrick J. Wong
2024-11-05 22:33 ` [PATCH 13/34] xfs: encode the rtsummary " Darrick J. Wong
2024-11-05 22:33 ` [PATCH 14/34] xfs: grow the realtime section when realtime groups are enabled Darrick J. Wong
2024-11-05 22:33 ` [PATCH 15/34] xfs: store rtgroup information with a bmap intent Darrick J. Wong
2024-11-05 22:34 ` [PATCH 16/34] xfs: force swapext to a realtime file to use the file content exchange ioctl Darrick J. Wong
2024-11-05 22:34 ` [PATCH 17/34] xfs: support logging EFIs for realtime extents Darrick J. Wong
2024-11-05 22:34 ` [PATCH 18/34] xfs: support error injection when freeing rt extents Darrick J. Wong
2024-11-05 22:34 ` [PATCH 19/34] xfs: use realtime EFI to free extents when rtgroups are enabled Darrick J. Wong
2024-11-05 22:35 ` [PATCH 20/34] xfs: don't merge ioends across RTGs Darrick J. Wong
2024-11-05 22:35 ` [PATCH 21/34] xfs: make the RT allocator rtgroup aware Darrick J. Wong
2024-11-05 22:35 ` [PATCH 22/34] xfs: don't coalesce file mappings that cross rtgroup boundaries in scrub Darrick J. Wong
2024-11-05 22:35 ` [PATCH 23/34] xfs: scrub the realtime group superblock Darrick J. Wong
2024-11-05 22:36 ` [PATCH 24/34] xfs: repair " Darrick J. Wong
2024-11-05 22:36 ` [PATCH 25/34] xfs: scrub metadir paths for rtgroup metadata Darrick J. Wong
2024-11-05 22:36 ` [PATCH 26/34] xfs: mask off the rtbitmap and summary inodes when metadir in use Darrick J. Wong
2024-11-05 22:36 ` [PATCH 27/34] xfs: create helpers to deal with rounding xfs_fileoff_t to rtx boundaries Darrick J. Wong
2024-11-05 22:37 ` [PATCH 28/34] xfs: create helpers to deal with rounding xfs_filblks_t " Darrick J. Wong
2024-11-05 22:37 ` [PATCH 29/34] xfs: make xfs_rtblock_t a segmented address like xfs_fsblock_t Darrick J. Wong
2024-11-05 22:37 ` [PATCH 30/34] xfs: adjust min_block usage in xfs_verify_agbno Darrick J. Wong
2024-11-05 22:37 ` [PATCH 31/34] xfs: move the min and max group block numbers to xfs_group Darrick J. Wong
2024-11-05 22:38 ` [PATCH 32/34] xfs: port the perag discard code to handle generic groups Darrick J. Wong
2024-11-05 22:38 ` [PATCH 33/34] xfs: implement busy extent tracking for rtgroups Darrick J. Wong
2024-11-05 22:38 ` [PATCH 34/34] xfs: use rtgroup busy extent list for FITRIM Darrick J. Wong
2024-11-05 22:05 ` [PATCHSET v5.5 07/10] xfs: persist quota options with metadir Darrick J. Wong
2024-11-05 22:39 ` [PATCH 1/4] xfs: refactor xfs_qm_destroy_quotainos Darrick J. Wong
2024-11-05 22:39 ` [PATCH 2/4] xfs: use metadir for quota inodes Darrick J. Wong
2024-11-05 22:39 ` [PATCH 3/4] xfs: scrub quota file metapaths Darrick J. Wong
2024-11-05 22:39 ` [PATCH 4/4] xfs: persist quota flags with metadir Darrick J. Wong
2024-11-05 22:05 ` [PATCHSET v5.5 08/10] xfs: enable quota for realtime volumes Darrick J. Wong
2024-11-05 22:40 ` [PATCH 1/6] xfs: fix chown with rt quota Darrick J. Wong
2024-11-05 22:40 ` [PATCH 2/6] xfs: advertise realtime quota support in the xqm stat files Darrick J. Wong
2024-11-05 22:40 ` [PATCH 3/6] xfs: report realtime block quota limits on realtime directories Darrick J. Wong
2024-11-05 22:40 ` [PATCH 4/6] xfs: create quota preallocation watermarks for realtime quota Darrick J. Wong
2024-11-05 22:41 ` [PATCH 5/6] xfs: reserve quota for realtime files correctly Darrick J. Wong
2024-11-05 22:41 ` [PATCH 6/6] xfs: enable realtime quota again Darrick J. Wong
2024-11-05 22:06 ` [PATCHSET v5.5 09/10] xfs: enable metadir Darrick J. Wong
2024-11-05 22:41 ` [PATCH 1/2] xfs: update sb field checks when metadir is turned on Darrick J. Wong
2024-11-05 22:41 ` [PATCH 2/2] xfs: enable metadata directory feature Darrick J. Wong
2024-11-05 22:06 ` [PATCHSET v5.5 10/10] xfs: improve ondisk structure checks Darrick J. Wong
2024-11-05 22:42 ` [PATCH 1/3] xfs: convert struct typedefs in xfs_ondisk.h Darrick J. Wong
2024-11-05 22:42 ` [PATCH 2/3] xfs: separate space btree structures " Darrick J. Wong
2024-11-05 22:42 ` [PATCH 3/3] xfs: port ondisk structure checks from xfs/122 to the kernel Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2024-10-17 18:46 [PATCHSET v5.1 4/9] xfs: create incore rt allocation groups Darrick J. Wong
2024-10-17 19:00 ` [PATCH 02/21] xfs: create incore realtime group structures Darrick J. Wong
2024-10-11 0:34 [PATCHSET v5.0 4/9] xfs: create incore rt allocation groups Darrick J. Wong
2024-10-11 0:56 ` [PATCH 02/21] xfs: create incore realtime group structures Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2AqZaGP587xtjWq@bfoster \
--to=bfoster@redhat.com \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox