Re: [PATCH] xfs: lock dquot buffer before detaching dquot from b_li_list

[Christoph Hellwig <hch@infradead.org>]

On Wed, Jan 08, 2025 at 11:17:18PM -0800, Darrick J. Wong wrote:
> > I did look a bit over how the inode items handles the equivalent
> > functionality, and AFAICS there is no direct one.  xfs_qm_dquot_isolate
> > is for shrinking the dquot LRU, which is handled through the VFS
> > for inodes.  xfs_qm_dqpurge tries to write back dirty dquots, which
> > I thought is dead code as all dirty dquots should have log
> > items and thus be handled through the log and AIL, but it seems like
> > xfs_qm_quotacheck_dqadjust dirties dquots without logging them.
> > So we'll need that for now, but I wonder if we should convert this
> > last bit of meatada to also go through our normal log mechanism
> > eventually?
> 
> What if we replace it with the one in scrub/repair_quotacheck.c? :)

Yes, that's a much better implementation.  It will probably be a while
until we can get everyone convinced to actually build the online repair
code into their kernels, though and I'm not sure if it's feasibable to
have a subset just for quotacheck.