From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Carlos Maiolino <cem@kernel.org>, xfs <linux-xfs@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] xfs: lock dquot buffer before detaching dquot from b_li_list
Date: Wed, 8 Jan 2025 22:08:05 -0800 [thread overview]
Message-ID: <Z39nxRk8AdTR3BCR@infradead.org> (raw)
In-Reply-To: <20250109005402.GH1387004@frogsfrogsfrogs>
On Wed, Jan 08, 2025 at 04:54:02PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> We have to lock the buffer before we can delete the dquot log item from
> the buffer's log item list.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
I did look a bit over how the inode items handles the equivalent
functionality, and AFAICS there is no direct one. xfs_qm_dquot_isolate
is for shrinking the dquot LRU, which is handled through the VFS
for inodes. xfs_qm_dqpurge tries to write back dirty dquots, which
I thought is dead code as all dirty dquots should have log
items and thus be handled through the log and AIL, but it seems like
xfs_qm_quotacheck_dqadjust dirties dquots without logging them.
So we'll need that for now, but I wonder if we should convert this
last bit of meatada to also go through our normal log mechanism
eventually?
next prev parent reply other threads:[~2025-01-09 6:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 0:54 [PATCH] xfs: lock dquot buffer before detaching dquot from b_li_list Darrick J. Wong
2025-01-09 6:08 ` Christoph Hellwig [this message]
2025-01-09 7:17 ` Darrick J. Wong
2025-01-09 7:35 ` Christoph Hellwig
2025-01-13 12:33 ` Carlos Maiolino
2025-01-13 16:21 ` Darrick J. Wong
2025-01-14 10:45 ` Carlos Maiolino
2025-01-14 15:53 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z39nxRk8AdTR3BCR@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox