From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF2374778E for ; Tue, 21 Jan 2025 03:06:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737428791; cv=none; b=RbVn3zroOVZg3HpJWf/m3SSeKXhTw7vGEN429AuxvbcmhS/32oJVe2SPiB4Un15I/QXoVKTu26VnffelChlOXuVUooXA90IdhbvqKVUNcVIpeLyTydJEna/EK+8gCEteD1g35ibZnIo7gbBSaKy4ELBmpMNNi+d8GhqN3lz7Evs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737428791; c=relaxed/simple; bh=fTCOHwghxZwsItwfMkEMxqGU8jkWXJmqiB8w2QMIrgM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jW/T6A8L9xuZLxsAx1dewL+5Z2qK04sO3foZ1FdWVZJOgX56AGPd1DaDD+5MAgVLEfxW6+GZWgneZqCdKcTVSt0PEdNDxBK4Cb1xO8WyuIRNo28AbMocPeBBBN4oZBh3XDPZzdNIf7uUT3WX6gNInf7+1Vsr3RXRe1Q3FptaiJo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com; spf=pass smtp.mailfrom=fromorbit.com; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b=sVt9fqEl; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b="sVt9fqEl" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2163dc5155fso95472335ad.0 for ; Mon, 20 Jan 2025 19:06:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1737428789; x=1738033589; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZI3aY4Vq2pZQ0VjDfrYHf67rBHg9IDKCbEXgpXPUjJA=; b=sVt9fqElvCK+RHMWgjsnx4+dconm3egEAWVFqceyxe89oDt8Zo5Sp1b010FaqcsCYu wLRZsdAiGDK3EKMEYMK9CRx80HRU5NjjcDgI6Aa00Nctz2j/7JzdS9OmXZPTA0+4O80R qWNXDeEd0Q1fdbuK9vE9lQ7MND2O31JAPBffdZCRLJYFh2Ot+3LlTnjhG9OU2OPqZ/CQ uLtFXZbizvVYR6LhHtHfrdz7niV8vz4pvkHH7Z2FsPmIOwtrOZRMlWNYnFjAk5Xe9C8j qB93GTAiClS8C+34FPRyqgxt4Qlwbo8dqTKlPWPynciEP160C3eO+xbxPs3tC0dIk1hw P0Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737428789; x=1738033589; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZI3aY4Vq2pZQ0VjDfrYHf67rBHg9IDKCbEXgpXPUjJA=; b=TSKtmALAR2Nsm5P53zLcyjw7jINZEDWcF6M3tS+NYqKn3aX5rQRfnssUat6xSPKrFK DO+qDvKAy4UQQi4gknCqsv6ecNW/cR4ieqJfy5e7Ce56MHvbcrekyDGK/UpSYqsT6RNr GKXQe+GvGy3JlFe/dWX/4V+oAgTgVHtyOhDx/iqeZEb5BWFxLQGUiSpCpXzttVW9SIya lBA7u7FlcPqnk352YmplvKjkbpf4ZVeJj/mHScZ3v8z/XkuEEcbyrrs5qf5/n4w49fwF SD5thIEUkpS9Xteko2r6eP4N8qhTvKsXVLElcJT6E46SPddS4blD+6ECcNCzABgEM5wt 773g== X-Forwarded-Encrypted: i=1; AJvYcCW29YZHLoleNmT31juIsbOpFzJfKdkT2e2f8tsCzr2Lcg6KtmmFiRHckbV4o0Hg6u8JJo4wGsfz+io=@vger.kernel.org X-Gm-Message-State: AOJu0YxrIj4thERSX2jr0mKgxgwsWU9otuOtsVfeXik/6hHf+fFR69oi iVLffd1mRpMqdogFqJ/cifSwnts+3j68ypl0HFRDOoryzLyfwUQzuKaIy9AtRUg= X-Gm-Gg: ASbGncspzfliTKmItiewH3w1EJ57CW8/Pg6/pScMCAeaVa94sLJJYj0deCcU1Lz0eDN bU1vGAJulfiOJOeZYcKfwib3eTpcV3NgaH+5Ap4w1JWn02VImHJo3MntyC1NEsw96+6dt5YoZDD Edebt/LphxkVBS2fa3e2/u4tDoSmIaAEstHxriGcwe4OGGfIXihf6UiLiKhVTW91YpJHHRbqYNI emyuaT/acICYTHhBHCh9mPfQ4E81X9em65xxWlfWzhwkfzi2Fi2NiEsXejn87NnUy5uG/Rl/H8G LAHw0ysjctwAMTfBLE1p/rA5VdqAmfllWv0= X-Google-Smtp-Source: AGHT+IErPG1DOtNBChTxF6hpTZqJbDbn63sjNQpRxuhYx5jT+hcgG7zBYpRIMdqaAhPVMlFVV3a09g== X-Received: by 2002:a17:903:120b:b0:216:1cfa:2bbf with SMTP id d9443c01a7336-21c355deb5bmr262807545ad.35.1737428789255; Mon, 20 Jan 2025 19:06:29 -0800 (PST) Received: from dread.disaster.area (pa49-186-89-135.pa.vic.optusnet.com.au. [49.186.89.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21c2d402d40sm67061165ad.231.2025.01.20.19.06.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2025 19:06:28 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.98) (envelope-from ) id 1ta4aw-00000008V9Y-0hlV; Tue, 21 Jan 2025 14:06:26 +1100 Date: Tue, 21 Jan 2025 14:06:26 +1100 From: Dave Chinner To: "Darrick J. Wong" Cc: zlang@redhat.com, hch@lst.de, fstests@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH 02/23] metadump: make non-local function variables more obvious Message-ID: References: <173706974044.1927324.7824600141282028094.stgit@frogsfrogsfrogs> <173706974107.1927324.17123378052376946322.stgit@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <173706974107.1927324.17123378052376946322.stgit@frogsfrogsfrogs> On Thu, Jan 16, 2025 at 03:25:42PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong > > In _xfs_verify_metadump_v2(), we want to set up some loop devices, > record the names of those loop devices, and then leave the variables in > the global namespace so that _xfs_cleanup_verify_metadump can dispose of > them. > > Elsewhere in fstests the convention for global variables is to put them > in all caps to make it obvious that they're global and not local > variables, so do that here too. I did this because they are local to the file and nothing external accesses them. So I converted them to be the same as all other file-scope loop device names which are all lower case. But it really doesn't matter at all, so if that's what you want then: Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com