From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7572714A619 for ; Wed, 22 Jan 2025 06:08:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737526102; cv=none; b=i8vD/0u6ZM4OUob10S95RUEdQCroTWp3c8yLay99aAZODXvsb76TzmNQ0GZ99O4H5mwihy+pB3AIn+aUDe6r8O6eH2Mi4SvdOC4wv5vPprDH4TYAIOX60ggLU5Ktlm0mBc69XCzSgvLGnJO40mMgx8wPvqMpKwb+ioXmTtSa0UI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737526102; c=relaxed/simple; bh=cQOe3nXGKxwa03Com2Yo1ruYoaCH9BEUj0RooxWz5mE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GQH9DkJm4GMRyshNXNYBFGCELCOpI5vUk5GseHYaG34RZIvekK8qRsJZYhnATVsv7qRtqyJ0qyoLYaQUiIDPngf9ytm+mDfMfgYvT7le8PD4jvuy86CYYtEl41OYBGtMaqnkRmYISVsqhUR96fDrHVu+9Mu/H7Zg47Zy2MqvCRc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com; spf=pass smtp.mailfrom=fromorbit.com; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b=DH0p7t5D; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b="DH0p7t5D" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2166651f752so150591915ad.3 for ; Tue, 21 Jan 2025 22:08:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1737526101; x=1738130901; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=T9PPmxYKawN84Zrla169U/qiFm4IJPFUiw6/SVFccUY=; b=DH0p7t5DTmHucO9Om5xfZzMGLiK5drLRCGDxLPpUGx/2Ibg+4X5t+cpi703Vmo+/oJ PRVMfIZ9GpA6u7L1vf/Nhh1mJhKjKaHPuy6lk/ze9UMa9aUdffF8otbbDc4gfHvm+Vjf 0hzkIoG0KY6X0yJjYkvQkBe0uJsb2drm2GG44zPspjYFntzPugG06C4N4BqDDOIb9/yB wwp1hQKS3B8xr85YTyHzquIkqhumqzindEB0tHoLb+7fO/Mu7PPHB+uy0cEjpX2keUkG DtpWkGxMGqd2cB5dUEYxQ9S04eqX3Dj6jwiNidiAlCi4Ga6IUipeEtabbaFt60dtdAvd mBYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737526101; x=1738130901; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T9PPmxYKawN84Zrla169U/qiFm4IJPFUiw6/SVFccUY=; b=ougmTUxDPoWQCt2eXGbMilt1/8s6nfVet35dvJitx0HCC5pcZXth7mHNqCZpY+JniQ efiFu0nandVnc1JYnTXTB8H2h5TmyLwmdyXKSMY57Bf5nAsvSw+TCp6+ourO3ZOhEUA1 cwh8J1r690tYQt/Vmyb5t9Fj/HQnGlsZBrX5Nl7OrysIVa5QW22/tUd/xTtTxraVmH5j 4gfLXPrZmSl25EXiD++O4ghtUthj+gxEtWU7v2Sjz6q5h+A5RUt7VN1M83M/EhEh5/bY UCyvPq5B1RrIEcEt/IQN2vnkz6CG7g2qxH+lnOjtXA+LRAv4yavGG4e06ihNgXNagCPL 8oZQ== X-Forwarded-Encrypted: i=1; AJvYcCVerR2zkO+ZjUajBJ2leASI7VyN1wGNnbM9RL1fmHZC/e7gFIsIVzfXx8ftywcAJKexeJuqRH9mbDo=@vger.kernel.org X-Gm-Message-State: AOJu0YxOdtLrHx9Vx45Pdm+E24dGE6H0Awnn9kTJVuCTISptk+DPbZge qK9KpQMklEbXlKW1lruH3fmj/rWFPWp9SHhe/hpjXbN+SSlj08NANlI4kVCtpSc= X-Gm-Gg: ASbGncuJPZwTA7bJD4xd9hh0nWdi83KnZwjxBSkzYvpYyGnaEOD3VZ8Y5PcdMtedTF0 9AFkX9lbIxoqI7eTvKB3++Mk0+K5xOOtr0G0KOGOWWhWwIbPPSahgpfkKQXVRpajj0Sp0o91T1L k3ngBGpv7DhhxYWVyfT3xUWMs7K7dbP4/Ml6OM2ZG/hte+V21sQ14GFm2fyCgdmozq0R6qvvHNn +uBtmhDS1A1YxOWw6c59+9jVLFvf+6w+l+0zwJrwVqAeioqjgkMA5xIntLBqA8MRph1NQjRUV77 xcyrP3QNhbrzAQCN0geeE/ddnQUEpdLzK3BeJ0HoQeiObw== X-Google-Smtp-Source: AGHT+IGXKFZz3j2qUqUrGo0iD44ewBXliPcEvdRgYvtV9aL062aB8F0vgX/4jqc8jy4OARlbR+0WUg== X-Received: by 2002:a17:902:f544:b0:215:e98c:c5bc with SMTP id d9443c01a7336-21c3563a33cmr355643705ad.48.1737526100764; Tue, 21 Jan 2025 22:08:20 -0800 (PST) Received: from dread.disaster.area (pa49-186-89-135.pa.vic.optusnet.com.au. [49.186.89.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21c2ceba906sm87713805ad.91.2025.01.21.22.08.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2025 22:08:20 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.98) (envelope-from ) id 1taTuT-00000008yMf-2ZHd; Wed, 22 Jan 2025 17:08:17 +1100 Date: Wed, 22 Jan 2025 17:08:17 +1100 From: Dave Chinner To: "Darrick J. Wong" Cc: zlang@redhat.com, hch@lst.de, fstests@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH 08/23] common: fix pkill by running test program in a separate session Message-ID: References: <173706974044.1927324.7824600141282028094.stgit@frogsfrogsfrogs> <173706974197.1927324.9208284704325894988.stgit@frogsfrogsfrogs> <20250122042400.GX1611770@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250122042400.GX1611770@frogsfrogsfrogs> On Tue, Jan 21, 2025 at 08:24:00PM -0800, Darrick J. Wong wrote: > On Tue, Jan 21, 2025 at 02:28:26PM +1100, Dave Chinner wrote: > > On Thu, Jan 16, 2025 at 03:27:15PM -0800, Darrick J. Wong wrote: > > > c) Putting test subprocesses in a systemd sub-scope and telling systemd > > > to kill the sub-scope could work because ./check can already use it to > > > ensure that all child processes of a test are killed. However, this is > > > an *optional* feature, which means that we'd have to require systemd. > > > > ... requiring systemd was somewhat of a show-stopper for testing > > older distros. > > Isn't RHEL7 the oldest one at this point? And it does systemd. At this > point the only reason I didn't go full systemd is out of consideration > for Devuan, since they probably need QA. I have no idea what is out there in distro land vs what fstests "supports". All I know is that there are distros out there that don't use systemd. It feels like poor form to prevent generic filesystem QA infrastructure from running on those distros by making an avoidable choice to tie the infrastructure exclusively to systemd-based functionality.... -Dave. -- Dave Chinner david@fromorbit.com