Re: [PATCH 09/23] unmount: resume logging of stdout and stderr for filtering

Darrick J. Wong
2025-01-22T03:29:11Z

On Tue, Jan 21, 2025 at 02:52:35PM +1100, Dave Chinner wrote:
> On Thu, Jan 16, 2025 at 03:27:31PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > There's a number of places where a test program calls a variant of
> > _unmount but then pipes the output through a _filter script or
> > something. The new _unmount helper redirects stdout and stderr to
> > seqres.full, which means that those error messages (some of which are
> > encoded in the golden outputs) are suppressed. This leads to test
> > regressions in generic/050 and other places, so let's resume logging.
>
> Huh. g/050 hasn't been failing in my test runs. Bizarre.

Yeah, it's bombing out here on the ro block device while trying to
enable quotas.

> Anyway, change looks fine.
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>

Thanks!

--D

> --
> Dave Chinner
> david@fromorbit.com
>