Re: [PATCH 19/23] common/rc: don't copy fsstress to $TEST_DIR

Darrick J. Wong
2025-01-22T03:52:23Z

On Tue, Jan 21, 2025 at 04:05:38PM +1100, Dave Chinner wrote:
> On Thu, Jan 16, 2025 at 03:30:07PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Now that we can pkill only processes that were started by this test, we
> > don't need to copy the fsstress binary to $TEST_DIR to avoid killing the
> > wrong program instances. This avoids a whole slew of ETXTBSY problems
> > with scrub stress tests that run multiple copies of fsstress in the
> > background.
> >
> > Revert most of the changes to generic/270, because it wants to do
> > something fancy with the fsstress binary, so it needs to control the
> > process directly.
> >
> > Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
>
> Change looks fine, though this should be a lot further up near the
> top of the patchset so that the change to g/482 and the revert here
> is not necessary at all.
>
> With that reordering done:
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>

Done, and thanks for responding to the big patch set.

--D

> --
> Dave Chinner
> david@fromorbit.com
>