Re: [PATCH 04/23] generic/482: _run_fsstress needs the test filesystem

Dave Chinner
2025-01-21T03:12:09Z

On Thu, Jan 16, 2025 at 03:26:13PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> The test filesystem is now a hard dependency of _run_fsstress because
> the latter copies the fsstress binary to a different name on the test
> filesystem:
>
> generic/482 - output mismatch (see /var/tmp/fstests/generic/482.out.bad)
> --- tests/generic/482.out 2024-02-28 16:20:24.262888854 -0800
> +++ /var/tmp/fstests/generic/482.out.bad 2025-01-03 15:00:43.107625116 -0800
> @@ -1,2 +1,3 @@
> QA output created by 482
> +cp: cannot create regular file '/mnt/482.fsstress': Read-only file system
> Silence is golden
> ...
> (Run 'diff -u /tmp/fstests/tests/generic/482.out /var/tmp/fstests/generic/482.out.bad' to see the entire diff)

Ah, because I hadn't added dm-logwrite support to check-parallel
this test wasn't being run....

However, this patch doesn't need to exist - this dependency is
removed later in the series by using the changes to use a unique
session ID for each test and so the fsstress binary doesn't need to
be rename. The change in this patch is then reverted....

I'd just drop this patch (and the later revert).

-Dave.

>
> Cc: <fstests@vger.kernel.org> # v2024.12.08
> Fixes: 8973af00ec212f ("fstests: cleanup fsstress process management")
> Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
> ---
> tests/generic/482 | 1 -
> 1 file changed, 1 deletion(-)
>
>
> diff --git a/tests/generic/482 b/tests/generic/482
> index 8c114ee03058c6..0efc026a160040 100755
> --- a/tests/generic/482
> +++ b/tests/generic/482
> @@ -68,7 +68,6 @@ lowspace=$((1024*1024 / 512)) # 1m low space threshold
>
> # Use a thin device to provide deterministic discard behavior. Discards are used
> # by the log replay tool for fast zeroing to prevent out-of-order replay issues.
> -_test_unmount
> _dmthin_init $devsize $devsize $csize $lowspace
> _log_writes_init $DMTHIN_VOL_DEV
> _log_writes_mkfs >> $seqres.full 2>&1
>
>
>

--
Dave Chinner
david@fromorbit.com