From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: cem@kernel.org, djwong@kernel.org, dchinner@redhat.com,
linux-xfs@vger.kernel.org, "Lai, Yi" <yi1.lai@linux.intel.com>,
Carlos Maiolino <cmaiolino@redhat.com>
Subject: Re: [PATCH v2] xfs: remove xfs_buf_cache.bc_lock
Date: Tue, 28 Jan 2025 17:44:53 +1100 [thread overview]
Message-ID: <Z5h85RIRAjXQizLz@dread.disaster.area> (raw)
In-Reply-To: <20250128052315.663868-1-hch@lst.de>
On Tue, Jan 28, 2025 at 06:22:58AM +0100, Christoph Hellwig wrote:
> xfs_buf_cache.bc_lock serializes adding buffers to and removing them from
> the hashtable. But as the rhashtable code already uses fine grained
> internal locking for inserts and removals the extra protection isn't
> actually required.
>
> It also happens to fix a lock order inversion vs b_lock added by the
> recent lookup race fix.
>
> Fixes: ee10f6fcdb96 ("xfs: fix buffer lookup vs release race")
> Reported-by: "Lai, Yi" <yi1.lai@linux.intel.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
>
> Changes since v1:
> - document the initial buffer state vs lockless lookups
Looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2025-01-28 6:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 5:22 [PATCH v2] xfs: remove xfs_buf_cache.bc_lock Christoph Hellwig
2025-01-28 6:44 ` Dave Chinner [this message]
2025-01-28 10:57 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5h85RIRAjXQizLz@dread.disaster.area \
--to=david@fromorbit.com \
--cc=cem@kernel.org \
--cc=cmaiolino@redhat.com \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=yi1.lai@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox