From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: zlang@redhat.com, linux-xfs@vger.kernel.org,
fstests@vger.kernel.org, Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>,
dm-devel@lists.linux.dev
Subject: Re: [PATCHSET 02/12] fstests: fix logwrites zeroing
Date: Tue, 18 Feb 2025 21:55:36 -0800 [thread overview]
Message-ID: <Z7VyWPjJM-M59wJc@infradead.org> (raw)
In-Reply-To: <173992586956.4078081.15131555531444924972.stgit@frogsfrogsfrogs>
I don't want to block this part as it's an improvement over the current
state, but all these games of trying to detect if discard zeroes all
data despite making no such guarantee whatsoever and being explicitly
allowed to zero some but not all data just feels wrong.
The right thing would be to use the BLKZEROOUT, but AFAIK the problem is
that dm-thin doesn't support that. Given that the dm-thin discard
implementation seems do always zero, it should be able to just be
reusable for BLKZEROOUT. Can the dm maintainers look into that as it
is a pretty glaring omission?
next prev parent reply other threads:[~2025-02-19 5:55 UTC|newest]
Thread overview: 176+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 0:43 [PATCHBOMB] fstests: catch us up to 6.12-6.14 changes Darrick J. Wong
2025-02-19 0:46 ` [PATCHSET 01/12] fstests: more random fixes for v2025.02.16 Darrick J. Wong
2025-02-19 0:49 ` [PATCH 1/2] dio-writeback-race: fix missing mode in O_CREAT Darrick J. Wong
2025-02-19 5:50 ` Christoph Hellwig
2025-02-19 0:49 ` [PATCH 2/2] dio_writeback_race: align the directio buffer to base page size Darrick J. Wong
2025-02-19 5:51 ` Christoph Hellwig
2025-02-19 5:55 ` Darrick J. Wong
2025-02-19 0:46 ` [PATCHSET 02/12] fstests: fix logwrites zeroing Darrick J. Wong
2025-02-19 0:49 ` [PATCH 1/3] logwrites: warn if we don't think read after discard returns zeroes Darrick J. Wong
2025-02-19 0:50 ` [PATCH 2/3] logwrites: use BLKZEROOUT if it's available Darrick J. Wong
2025-02-19 0:50 ` [PATCH 3/3] logwrites: only use BLKDISCARD if we know discard zeroes data Darrick J. Wong
2025-02-19 5:55 ` Christoph Hellwig [this message]
2025-02-19 6:13 ` [PATCHSET 02/12] fstests: fix logwrites zeroing Darrick J. Wong
2025-02-19 6:20 ` Christoph Hellwig
2025-02-19 0:46 ` [PATCHSET v32.1 03/12] fstests: fix online and offline fsck test groups Darrick J. Wong
2025-02-19 0:50 ` [PATCH 01/12] misc: drop the dangerous label from xfs_scrub fsstress tests Darrick J. Wong
2025-02-19 5:56 ` Christoph Hellwig
2025-02-19 0:50 ` [PATCH 02/12] misc: rename the dangerous_repair group to fuzzers_repair Darrick J. Wong
2025-02-19 5:56 ` Christoph Hellwig
2025-02-19 0:51 ` [PATCH 03/12] misc: rename the dangerous_online_repair group to fuzzers_online_repair Darrick J. Wong
2025-02-19 5:57 ` Christoph Hellwig
2025-02-19 0:51 ` [PATCH 04/12] misc: rename the dangerous_bothrepair group to fuzzers_bothrepair Darrick J. Wong
2025-02-19 5:57 ` Christoph Hellwig
2025-02-19 0:51 ` [PATCH 05/12] misc: rename the dangerous_norepair group to fuzzers_norepair Darrick J. Wong
2025-02-19 5:58 ` Christoph Hellwig
2025-02-19 0:51 ` [PATCH 06/12] misc: fix misclassification of xfs_repair fuzz tests Darrick J. Wong
2025-02-19 5:58 ` Christoph Hellwig
2025-02-19 0:52 ` [PATCH 07/12] misc: fix misclassification of xfs_scrub + " Darrick J. Wong
2025-02-19 5:59 ` Christoph Hellwig
2025-02-19 0:52 ` [PATCH 08/12] misc: fix misclassification of verifier " Darrick J. Wong
2025-02-19 5:59 ` Christoph Hellwig
2025-02-19 0:52 ` [PATCH 09/12] misc: add xfs_scrub + xfs_repair fuzz tests to the scrub and repair groups Darrick J. Wong
2025-02-19 5:59 ` Christoph Hellwig
2025-02-19 0:52 ` [PATCH 10/12] misc: remove the dangerous_scrub group Darrick J. Wong
2025-02-19 6:00 ` Christoph Hellwig
2025-02-19 0:53 ` [PATCH 11/12] xfs/28[56],xfs/56[56]: add to the auto group Darrick J. Wong
2025-02-19 6:00 ` Christoph Hellwig
2025-02-19 6:05 ` Darrick J. Wong
2025-02-19 6:08 ` Christoph Hellwig
2025-02-19 6:13 ` Darrick J. Wong
2025-02-19 0:53 ` [PATCH 12/12] xfs/349: reclassify this test as not dangerous Darrick J. Wong
2025-02-19 6:01 ` Christoph Hellwig
2025-02-19 0:46 ` [PATCHSET v6.4 04/12] fstests: enable metadir Darrick J. Wong
2025-02-19 0:53 ` [PATCH 01/12] various: fix finding metadata inode numbers when metadir is enabled Darrick J. Wong
2025-02-19 6:02 ` Christoph Hellwig
2025-02-19 0:53 ` [PATCH 02/12] xfs/{030,033,178}: forcibly disable metadata directory trees Darrick J. Wong
2025-02-19 6:03 ` Christoph Hellwig
2025-02-19 0:54 ` [PATCH 03/12] common/repair: patch up repair sb inode value complaints Darrick J. Wong
2025-02-19 6:03 ` Christoph Hellwig
2025-02-19 0:54 ` [PATCH 04/12] xfs/206: update for metadata directory support Darrick J. Wong
2025-02-19 6:04 ` Christoph Hellwig
2025-02-19 0:54 ` [PATCH 05/12] xfs/{050,144,153,299,330}: update quota reports to handle metadir trees Darrick J. Wong
2025-02-19 6:04 ` Christoph Hellwig
2025-02-19 0:55 ` [PATCH 06/12] xfs/509: adjust inumbers accounting for metadata directories Darrick J. Wong
2025-02-19 6:05 ` Christoph Hellwig
2025-02-19 0:55 ` [PATCH 07/12] xfs: create fuzz tests " Darrick J. Wong
2025-02-19 6:05 ` Christoph Hellwig
2025-02-19 0:55 ` [PATCH 08/12] xfs/163: bigger fs for metadir Darrick J. Wong
2025-02-19 6:06 ` Christoph Hellwig
2025-02-19 0:55 ` [PATCH 09/12] xfs/122: disable this test for any codebase that knows about metadir Darrick J. Wong
2025-02-19 6:06 ` Christoph Hellwig
2025-02-19 0:56 ` [PATCH 10/12] common/populate: label newly created xfs filesystems Darrick J. Wong
2025-02-19 6:06 ` Christoph Hellwig
2025-02-19 0:56 ` [PATCH 11/12] scrub: race metapath online fsck with fsstress Darrick J. Wong
2025-02-19 6:07 ` Christoph Hellwig
2025-02-19 0:56 ` [PATCH 12/12] xfs: test metapath repairs Darrick J. Wong
2025-02-19 6:07 ` Christoph Hellwig
2025-02-19 0:47 ` [PATCHSET v6.4 05/12] fstests: make protofiles less janky Darrick J. Wong
2025-02-19 0:56 ` [PATCH 1/4] xfs/019: reduce _fail calls in test Darrick J. Wong
2025-02-19 6:08 ` Christoph Hellwig
2025-02-19 0:57 ` [PATCH 2/4] xfs/019: test reserved file support Darrick J. Wong
2025-02-19 6:09 ` Christoph Hellwig
2025-02-19 0:57 ` [PATCH 3/4] xfs: test filesystem creation with xfs_protofile Darrick J. Wong
2025-02-19 6:09 ` Christoph Hellwig
2025-02-19 0:57 ` [PATCH 4/4] fstests: test mkfs.xfs protofiles with xattr support Darrick J. Wong
2025-02-19 6:09 ` Christoph Hellwig
2025-02-19 0:47 ` [PATCHSET v6.4 06/12] fstests: shard the realtime section Darrick J. Wong
2025-02-19 0:57 ` [PATCH 01/15] common/populate: refactor caching of metadumps to a helper Darrick J. Wong
2025-02-19 7:12 ` Christoph Hellwig
2025-02-19 0:58 ` [PATCH 02/15] common/{fuzzy,populate}: use _scratch_xfs_mdrestore Darrick J. Wong
2025-02-19 7:12 ` Christoph Hellwig
2025-02-19 0:58 ` [PATCH 03/15] fuzzy: stress data and rt sections of xfs filesystems equally Darrick J. Wong
2025-02-19 7:13 ` Christoph Hellwig
2025-02-19 0:58 ` [PATCH 04/15] fuzzy: run fsx on " Darrick J. Wong
2025-02-19 7:13 ` Christoph Hellwig
2025-02-19 0:58 ` [PATCH 05/15] common/ext4: reformat external logs during mdrestore operations Darrick J. Wong
2025-02-19 7:14 ` Christoph Hellwig
2025-02-19 0:59 ` [PATCH 06/15] common/populate: use metadump v2 format by default for fs metadata snapshots Darrick J. Wong
2025-02-19 7:14 ` Christoph Hellwig
2025-02-19 0:59 ` [PATCH 07/15] punch-alternating: detect xfs realtime files with large allocation units Darrick J. Wong
2025-02-19 7:14 ` Christoph Hellwig
2025-02-19 0:59 ` [PATCH 08/15] xfs/206: update mkfs filtering for rt groups feature Darrick J. Wong
2025-02-19 7:15 ` Christoph Hellwig
2025-02-19 0:59 ` [PATCH 09/15] common: pass the realtime device to xfs_db when possible Darrick J. Wong
2025-02-19 7:15 ` Christoph Hellwig
2025-02-19 1:00 ` [PATCH 10/15] xfs/185: update for rtgroups Darrick J. Wong
2025-02-19 7:16 ` Christoph Hellwig
2025-02-19 1:00 ` [PATCH 11/15] xfs/449: update test to know about xfs_db -R Darrick J. Wong
2025-02-19 7:16 ` Christoph Hellwig
2025-02-19 1:00 ` [PATCH 12/15] xfs/271,xfs/556: fix tests to deal with rtgroups output in bmap/fsmap commands Darrick J. Wong
2025-02-19 7:17 ` Christoph Hellwig
2025-02-19 1:01 ` [PATCH 13/15] common/xfs: capture realtime devices during metadump/mdrestore Darrick J. Wong
2025-02-19 7:17 ` Christoph Hellwig
2025-02-19 1:01 ` [PATCH 14/15] common/fuzzy: adapt the scrub stress tests to support rtgroups Darrick J. Wong
2025-02-19 7:17 ` Christoph Hellwig
2025-02-19 1:01 ` [PATCH 15/15] xfs: fix fuzz tests of rtgroups bitmap and summary files Darrick J. Wong
2025-02-19 7:18 ` Christoph Hellwig
2025-02-19 0:47 ` [PATCHSET v6.4 07/12] fstests: store quota files in the metadir Darrick J. Wong
2025-02-19 1:01 ` [PATCH 1/4] xfs: update tests for " Darrick J. Wong
2025-02-19 7:19 ` Christoph Hellwig
2025-02-19 1:02 ` [PATCH 2/4] xfs: test persistent quota flags Darrick J. Wong
2025-02-19 7:20 ` Christoph Hellwig
2025-02-19 1:02 ` [PATCH 3/4] xfs: fix quota detection in fuzz tests Darrick J. Wong
2025-02-19 7:20 ` Christoph Hellwig
2025-02-19 1:02 ` [PATCH 4/4] xfs: fix tests for persistent qflags Darrick J. Wong
2025-02-19 7:20 ` Christoph Hellwig
2025-02-19 7:19 ` [PATCHSET v6.4 07/12] fstests: store quota files in the metadir Christoph Hellwig
2025-02-19 16:57 ` Darrick J. Wong
2025-02-19 0:47 ` [PATCHSET v6.4 08/12] fstests: enable quota for realtime volumes Darrick J. Wong
2025-02-19 1:02 ` [PATCH 1/3] common: enable testing of realtime quota when supported Darrick J. Wong
2025-02-19 7:21 ` Christoph Hellwig
2025-02-19 1:03 ` [PATCH 2/3] xfs: fix quota tests to adapt to realtime quota Darrick J. Wong
2025-02-19 7:21 ` Christoph Hellwig
2025-02-19 1:03 ` [PATCH 3/3] xfs: regression testing of quota on the realtime device Darrick J. Wong
2025-02-19 7:21 ` Christoph Hellwig
2025-02-19 0:48 ` [PATCHSET 09/12] fstests: check new 6.14 behaviors Darrick J. Wong
2025-02-19 1:03 ` [PATCH 1/1] common: test statfs reporting with project quota Darrick J. Wong
2025-02-19 7:22 ` Christoph Hellwig
2025-02-19 0:48 ` [PATCHSET v6.4 10/12] fstests: realtime reverse-mapping support Darrick J. Wong
2025-02-19 1:03 ` [PATCH 01/13] xfs: fix tests that try to access the realtime rmap inode Darrick J. Wong
2025-02-19 7:24 ` Christoph Hellwig
2025-02-19 1:04 ` [PATCH 02/13] xfs/336: port to common/metadump Darrick J. Wong
2025-02-19 7:24 ` Christoph Hellwig
2025-02-19 1:04 ` [PATCH 03/13] fuzz: for fuzzing the rtrmapbt, find the path to the rt rmap btree file Darrick J. Wong
2025-02-19 7:25 ` Christoph Hellwig
2025-02-19 1:04 ` [PATCH 04/13] xfs: race fsstress with realtime rmap btree scrub and repair Darrick J. Wong
2025-02-19 7:26 ` Christoph Hellwig
2025-02-19 1:04 ` [PATCH 05/13] xfs: fix various problems with fsmap detecting the data device Darrick J. Wong
2025-02-19 7:27 ` Christoph Hellwig
2025-02-19 1:05 ` [PATCH 06/13] xfs/341: update test for rtgroup-based rmap Darrick J. Wong
2025-02-19 7:27 ` Christoph Hellwig
2025-02-19 1:05 ` [PATCH 07/13] xfs/3{43,32}: adapt tests for rt extent size greater than 1 Darrick J. Wong
2025-02-19 7:27 ` Christoph Hellwig
2025-02-19 1:05 ` [PATCH 08/13] xfs/291: use _scratch_mkfs_sized instead of opencoding the logic Darrick J. Wong
2025-02-19 7:28 ` Christoph Hellwig
2025-02-19 1:05 ` [PATCH 09/13] xfs: skip tests if formatting small filesystem fails Darrick J. Wong
2025-02-19 7:30 ` Christoph Hellwig
2025-02-19 17:13 ` Darrick J. Wong
2025-02-19 19:17 ` [PATCH v6.4.1 09/13] xfs/104: use _scratch_mkfs_sized Darrick J. Wong
2025-02-20 6:17 ` Christoph Hellwig
2025-02-19 1:06 ` [PATCH 10/13] xfs/443: use file allocation unit, not dbsize Darrick J. Wong
2025-02-19 7:31 ` Christoph Hellwig
2025-02-19 1:06 ` [PATCH 11/13] populate: adjust rtrmap calculations for rtgroups Darrick J. Wong
2025-02-19 7:32 ` Christoph Hellwig
2025-02-19 1:06 ` [PATCH 12/13] populate: check that we created a realtime rmap btree of the given height Darrick J. Wong
2025-02-19 7:32 ` Christoph Hellwig
2025-02-19 1:07 ` [PATCH 13/13] fuzzy: create missing fuzz tests for rt rmap btrees Darrick J. Wong
2025-02-19 7:32 ` Christoph Hellwig
2025-02-19 0:48 ` [PATCHSET v6.4 11/12] fstests: reflink on the realtime device Darrick J. Wong
2025-02-19 1:07 ` [PATCH 1/7] common/populate: create realtime refcount btree Darrick J. Wong
2025-02-19 7:41 ` Christoph Hellwig
2025-02-19 1:07 ` [PATCH 2/7] xfs: create fuzz tests for the " Darrick J. Wong
2025-02-19 7:42 ` Christoph Hellwig
2025-02-19 1:07 ` [PATCH 3/7] xfs/27[24]: adapt for checking files on the realtime volume Darrick J. Wong
2025-02-19 7:42 ` Christoph Hellwig
2025-02-19 1:08 ` [PATCH 4/7] xfs: race fsstress with realtime refcount btree scrub and repair Darrick J. Wong
2025-02-19 7:43 ` Christoph Hellwig
2025-02-19 1:08 ` [PATCH 5/7] xfs: remove xfs/131 now that we allow reflink on realtime volumes Darrick J. Wong
2025-02-19 7:43 ` Christoph Hellwig
2025-02-19 1:08 ` [PATCH 6/7] generic/331,xfs/240: support files that skip delayed allocation Darrick J. Wong
2025-02-19 7:44 ` Christoph Hellwig
2025-02-19 1:08 ` [PATCH 7/7] common/xfs: fix _xfs_get_file_block_size when rtinherit is set and no rt section Darrick J. Wong
2025-02-19 7:44 ` Christoph Hellwig
2025-02-19 0:49 ` [PATCHSET 12/12] fstests: dump fs directory trees Darrick J. Wong
2025-02-19 1:09 ` [PATCH 1/1] xfs: test filesystem recovery with rdump Darrick J. Wong
2025-02-19 7:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7VyWPjJM-M59wJc@infradead.org \
--to=hch@infradead.org \
--cc=agk@redhat.com \
--cc=djwong@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox