From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: aalbersh@kernel.org, linux-xfs@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH 2/4] xfs_repair: fix crash in reset_rt_metadir_inodes
Date: Sat, 22 Mar 2025 23:34:09 -0700 [thread overview]
Message-ID: <Z9-rYZFH78Eb45XC@infradead.org> (raw)
In-Reply-To: <174257453632.474645.11619039334465128305.stgit@frogsfrogsfrogs>
On Fri, Mar 21, 2025 at 09:31:46AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> I observed that xfs_repair -n segfaults during xfs/812 after corrupting
> the /rtgroups metadir inode because mp->m_rtdirip isn't loaded. Fix the
> crash and print a warning about the missing inode.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-03-23 6:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 16:26 [PATCHBOMB] xfsprogs: last few fixes for 6.14 Darrick J. Wong
2025-03-21 16:30 ` [PATCHSET 1/2] xfsprogs: new libxfs code from kernel 6.14 Darrick J. Wong
2025-03-21 16:31 ` [PATCH 1/1] xfs: Use abs_diff instead of XFS_ABSDIFF Darrick J. Wong
2025-03-21 16:30 ` [PATCHSET 2/2] xfsprogs: random bug fixes Darrick J. Wong
2025-03-21 16:31 ` [PATCH 1/4] xfs_repair: don't recreate /quota metadir if there are no quota inodes Darrick J. Wong
2025-03-21 17:58 ` Andrey Albershteyn
2025-03-23 6:33 ` Christoph Hellwig
2025-03-25 0:54 ` Darrick J. Wong
2025-03-21 16:31 ` [PATCH 2/4] xfs_repair: fix crash in reset_rt_metadir_inodes Darrick J. Wong
2025-03-23 6:34 ` Christoph Hellwig [this message]
2025-03-21 16:32 ` [PATCH 3/4] xfs_repair: fix infinite loop in longform_dir2_entry_check* Darrick J. Wong
2025-03-23 6:34 ` Christoph Hellwig
2025-03-21 16:32 ` [PATCH 4/4] xfs_repair: fix stupid argument error in verify_inode_chunk Darrick J. Wong
2025-03-23 6:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9-rYZFH78Eb45XC@infradead.org \
--to=hch@infradead.org \
--cc=aalbersh@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox