* [PATCH -next] xfs: Remove duplicate xfs_rtbitmap.h header
@ 2025-03-12 1:44 ` Jiapeng Chong
2025-03-12 5:35 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jiapeng Chong @ 2025-03-12 1:44 UTC (permalink / raw)
To: cem; +Cc: djwong, linux-xfs, linux-kernel, Jiapeng Chong, Abaci Robot
./fs/xfs/libxfs/xfs_sb.c: xfs_rtbitmap.h is included more than once.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=19446
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
fs/xfs/libxfs/xfs_sb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c
index e42bfd04a7c6..711e180f9ebb 100644
--- a/fs/xfs/libxfs/xfs_sb.c
+++ b/fs/xfs/libxfs/xfs_sb.c
@@ -30,7 +30,6 @@
#include "xfs_rtgroup.h"
#include "xfs_rtrmap_btree.h"
#include "xfs_rtrefcount_btree.h"
-#include "xfs_rtbitmap.h"
/*
* Physical superblock buffer manipulations. Shared with libxfs in userspace.
--
2.32.0.3.g01195cf9f
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] xfs: Remove duplicate xfs_rtbitmap.h header
2025-03-12 1:44 ` [PATCH -next] xfs: Remove duplicate xfs_rtbitmap.h header Jiapeng Chong
@ 2025-03-12 5:35 ` Christoph Hellwig
2025-03-12 9:01 ` Carlos Maiolino
2025-03-14 13:33 ` Carlos Maiolino
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2025-03-12 5:35 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: cem, djwong, linux-xfs, linux-kernel, Abaci Robot
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] xfs: Remove duplicate xfs_rtbitmap.h header
2025-03-12 1:44 ` [PATCH -next] xfs: Remove duplicate xfs_rtbitmap.h header Jiapeng Chong
2025-03-12 5:35 ` Christoph Hellwig
@ 2025-03-12 9:01 ` Carlos Maiolino
2025-03-14 13:33 ` Carlos Maiolino
2 siblings, 0 replies; 4+ messages in thread
From: Carlos Maiolino @ 2025-03-12 9:01 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: djwong, linux-xfs, linux-kernel, Abaci Robot
On Wed, Mar 12, 2025 at 09:44:51AM +0800, Jiapeng Chong wrote:
> ./fs/xfs/libxfs/xfs_sb.c: xfs_rtbitmap.h is included more than once.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=19446
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
This fixes an issue on the zoned device series, so, I'm adding to the commit:
Fixes: 2167eaabe2fa ("xfs: define the zoned on-disk format")
Thanks!
> ---
> fs/xfs/libxfs/xfs_sb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c
> index e42bfd04a7c6..711e180f9ebb 100644
> --- a/fs/xfs/libxfs/xfs_sb.c
> +++ b/fs/xfs/libxfs/xfs_sb.c
> @@ -30,7 +30,6 @@
> #include "xfs_rtgroup.h"
> #include "xfs_rtrmap_btree.h"
> #include "xfs_rtrefcount_btree.h"
> -#include "xfs_rtbitmap.h"
>
> /*
> * Physical superblock buffer manipulations. Shared with libxfs in userspace.
> --
> 2.32.0.3.g01195cf9f
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] xfs: Remove duplicate xfs_rtbitmap.h header
2025-03-12 1:44 ` [PATCH -next] xfs: Remove duplicate xfs_rtbitmap.h header Jiapeng Chong
2025-03-12 5:35 ` Christoph Hellwig
2025-03-12 9:01 ` Carlos Maiolino
@ 2025-03-14 13:33 ` Carlos Maiolino
2 siblings, 0 replies; 4+ messages in thread
From: Carlos Maiolino @ 2025-03-14 13:33 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: djwong, linux-xfs, linux-kernel, Abaci Robot
On Wed, 12 Mar 2025 09:44:51 +0800, Jiapeng Chong wrote:
> ./fs/xfs/libxfs/xfs_sb.c: xfs_rtbitmap.h is included more than once.
>
>
Applied to for-next, thanks!
[1/1] xfs: Remove duplicate xfs_rtbitmap.h header
commit: fcb255537bee25560af03c583b44866e73a8eb40
Best regards,
--
Carlos Maiolino <cem@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-14 13:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <YzvkMRRar3xemUncZt-_Xv4nHj7Ido5R9mMgNEr4OWSIn_XQ5QpUzpW-ByTDbnQE1ifB-gmmRFZ-iATh1b06pA==@protonmail.internalid>
2025-03-12 1:44 ` [PATCH -next] xfs: Remove duplicate xfs_rtbitmap.h header Jiapeng Chong
2025-03-12 5:35 ` Christoph Hellwig
2025-03-12 9:01 ` Carlos Maiolino
2025-03-14 13:33 ` Carlos Maiolino
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox