public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Leah Rumancik <leah.rumancik@gmail.com>
Cc: linux-xfs@vger.kernel.org, amir73il@gmail.com, chandan.babu@oracle.com
Subject: Re: [PATCH 5.15 CANDIDATE 00/11] 5.15.y sgid fixes
Date: Fri, 3 Mar 2023 08:51:01 -0800	[thread overview]
Message-ID: <ZAIldWNxBWIazAuP@magnolia> (raw)
In-Reply-To: <20230302203504.2998773-1-leah.rumancik@gmail.com>

On Thu, Mar 02, 2023 at 12:34:53PM -0800, Leah Rumancik wrote:
> Hello,
> 
> I finished testing the sgid fixes which Amir graciously backported to
> 5.15. This series fixes the previously failing generic/673 and
> generic/68[3-7]. No regressions were seen in the 25 runs of the auto
> group x 8 configs. I also did some extra runs on the perms group and
> no regressions there either. The corresponding fixes are already in
> 6.1.y.

If Christian is ok with backporting all the setgid changes to 5.15,

Acked-by: Darrick J. Wong <djwong@kernel.org>

--D

> 
> - Leah
> 
> Christian Brauner (5):
>   attr: add in_group_or_capable()
>   fs: move should_remove_suid()
>   attr: add setattr_should_drop_sgid()
>   attr: use consistent sgid stripping checks
>   fs: use consistent setgid checks in is_sxid()
> 
> Darrick J. Wong (1):
>   xfs: use setattr_copy to set vfs inode attributes
> 
> Dave Chinner (3):
>   xfs: remove XFS_PREALLOC_SYNC
>   xfs: fallocate() should call file_modified()
>   xfs: set prealloc flag in xfs_alloc_file_space()
> 
> Yang Xu (2):
>   fs: add mode_strip_sgid() helper
>   fs: move S_ISGID stripping into the vfs_*() helpers
> 
>  Documentation/trace/ftrace.rst |  2 +-
>  fs/attr.c                      | 72 +++++++++++++++++++++++++--
>  fs/fuse/file.c                 |  2 +-
>  fs/inode.c                     | 90 ++++++++++++++++++++--------------
>  fs/internal.h                  | 10 +++-
>  fs/namei.c                     | 82 ++++++++++++++++++++++++++-----
>  fs/ocfs2/file.c                |  4 +-
>  fs/ocfs2/namei.c               |  1 +
>  fs/open.c                      |  8 +--
>  fs/xfs/xfs_bmap_util.c         |  9 ++--
>  fs/xfs/xfs_file.c              | 24 +++++----
>  fs/xfs/xfs_iops.c              | 56 ++-------------------
>  fs/xfs/xfs_pnfs.c              |  9 ++--
>  include/linux/fs.h             |  6 ++-
>  14 files changed, 235 insertions(+), 140 deletions(-)
> 
> -- 
> 2.40.0.rc0.216.gc4246ad0f0-goog
> 

      parent reply	other threads:[~2023-03-03 16:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-02 20:34 [PATCH 5.15 CANDIDATE 00/11] 5.15.y sgid fixes Leah Rumancik
2023-03-02 20:34 ` [PATCH 5.15 CANDIDATE 01/11] xfs: use setattr_copy to set vfs inode attributes Leah Rumancik
2023-03-02 20:34 ` [PATCH 5.15 CANDIDATE 02/11] xfs: remove XFS_PREALLOC_SYNC Leah Rumancik
2023-03-02 20:34 ` [PATCH 5.15 CANDIDATE 03/11] xfs: fallocate() should call file_modified() Leah Rumancik
2023-03-02 20:34 ` [PATCH 5.15 CANDIDATE 04/11] xfs: set prealloc flag in xfs_alloc_file_space() Leah Rumancik
2023-03-02 20:34 ` [PATCH 5.15 CANDIDATE 05/11] fs: add mode_strip_sgid() helper Leah Rumancik
2023-03-02 20:34 ` [PATCH 5.15 CANDIDATE 06/11] fs: move S_ISGID stripping into the vfs_*() helpers Leah Rumancik
2023-03-02 20:35 ` [PATCH 5.15 CANDIDATE 07/11] attr: add in_group_or_capable() Leah Rumancik
2023-03-02 20:35 ` [PATCH 5.15 CANDIDATE 08/11] fs: move should_remove_suid() Leah Rumancik
2023-03-02 20:35 ` [PATCH 5.15 CANDIDATE 09/11] attr: add setattr_should_drop_sgid() Leah Rumancik
2023-03-02 20:35 ` [PATCH 5.15 CANDIDATE 10/11] attr: use consistent sgid stripping checks Leah Rumancik
2023-03-02 20:35 ` [PATCH 5.15 CANDIDATE 11/11] fs: use consistent setgid checks in is_sxid() Leah Rumancik
2023-03-03 16:51 ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZAIldWNxBWIazAuP@magnolia \
    --to=djwong@kernel.org \
    --cc=amir73il@gmail.com \
    --cc=chandan.babu@oracle.com \
    --cc=leah.rumancik@gmail.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox