From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: add tracepoints for each of the externally visible allocators
Date: Sat, 18 Mar 2023 11:39:14 +1100 [thread overview]
Message-ID: <ZBUIMllXvBrvP9md@destitution> (raw)
In-Reply-To: <20230316164743.GL11376@frogsfrogsfrogs>
On Thu, Mar 16, 2023 at 09:47:43AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> There are now five separate space allocator interfaces exposed to the
> rest of XFS for five different strategies to find space. Add
> tracepoints for each of them so that I can tell from a trace dump
> exactly which ones got called and what happened underneath them. Add a
> sixth so it's more obvious if an allocation actually happened.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> fs/xfs/libxfs/xfs_alloc.c | 17 +++++++++++++++++
> fs/xfs/xfs_trace.h | 7 +++++++
> 2 files changed, 24 insertions(+)
Makes sense.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2023-03-18 0:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 16:47 [PATCH] xfs: add tracepoints for each of the externally visible allocators Darrick J. Wong
2023-03-18 0:39 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBUIMllXvBrvP9md@destitution \
--to=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox